Add a POSIX C LDK networking library #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and OSX complains that "redefinition of typedef...is a C11 feature"
TheBlueMatt
force-pushed
the
main
branch
2 times, most recently
from
ec0b57e to
35c9191
Compare
Collaborator
Author
|
Updated to upstream + lightningdevkit/rust-lightning#988 (which hopefully will go in 0.0.99). |
jkczyz
reviewed
Jul 8, 2021
Contributor
jkczyz
left a comment
jkczyz
left a comment
There was a problem hiding this comment.
Reviewed at a very high-level. Unable to run because demo.cpp needs to updated (see comment).
It appears somehow the LLVM IR is slipping into the Rust library, causing Ubunto link to fail with the following error: /usr/bin/ld: error: LLVM gold plugin has failed to create LTO module: Invalid record clang: error: linker command failed with exit code 1 (use -v to see invocation)
Collaborator
Author
|
Updated to latest upstream again. |
jkczyz
approved these changes
Jul 9, 2021
lightning-c-bindings/Cargo.toml
Outdated
Comment on lines
21
to
24
| lightning = { git = "https://github.com/rust-bitcoin/rust-lightning", rev = "865c6ba04eef70ed33afe484e9df7d12093fc598", features = ["allow_wallclock_use"] } | ||
| lightning-persister = { git = "https://github.com/rust-bitcoin/rust-lightning", rev = "865c6ba04eef70ed33afe484e9df7d12093fc598" } | ||
| lightning-invoice = { git = "https://github.com/rust-bitcoin/rust-lightning", rev = "865c6ba04eef70ed33afe484e9df7d12093fc598" } | ||
| lightning-background-processor = { git = "https://github.com/rust-bitcoin/rust-lightning", rev = "865c6ba04eef70ed33afe484e9df7d12093fc598" } |
Contributor
There was a problem hiding this comment.
I take it this needs to be updated for 0.0.99?
Collaborator
Author
There was a problem hiding this comment.
Huh! I'd intended to, but apparently set it to the wrong value. In any case I'll need to update it one more time before merge once 0.0.99 is tagged upstream, but that just changes the last commit so I won't bother with re-review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out there is no good option in swift, so we should just do it in C here.