resolving #218

Author: czurnieden

bn_mp_ilogb.c

@@ -7,8 +7,8 @@
 static mp_word s_pow(mp_word base, mp_word exponent)
 {
    mp_word result = 1uLL;
-   while (exponent) {
-      if ((exponent & 0x1) == 1) {
+   while (exponent != 0u) {
+      if ((exponent & 1u) == 1u) {
          result *= base;
       }
       exponent >>= 1;
@@ -85,13 +85,17 @@ int mp_ilogb(mp_int *a, mp_digit base, mp_int *c)
       return MP_VAL;
    }
 
-   if (base < 2) {
+   if (base < 2u) {
       return MP_VAL;
-   } else if (base == 2) {
+   }
+   if (base == 2u) {
       cmp = mp_count_bits(a) - 1;
-      mp_set_int(c, (unsigned long)cmp);
+      if ((e = mp_set_int(c, (unsigned long)cmp)) != MP_OKAY) {
+         goto LTM_ERR;
+      }
       return err;
-   } else if (a->used == 1) {
+   }
+   if (a->used == 1) {
       tmp = s_digit_ilogb(base, a->dp[0]);
       mp_set(c, tmp);
       return err;
@@ -114,9 +118,9 @@ int mp_ilogb(mp_int *a, mp_digit base, mp_int *c)
       return err;
    }
 
-   low = 0uL;
+   low = 0u;
    mp_set(&bracket_low, 1uL);
-   high = 1uL;
+   high = 1u;
 
    mp_set(&bracket_high, base);
 
@@ -138,14 +142,14 @@ int mp_ilogb(mp_int *a, mp_digit base, mp_int *c)
    }
    mp_set(&bi_base, base);
 
-   while ((high - low) > 1) {
+   while ((high - low) > 1u) {
       mid = (high + low) >> 1;
       /* Difference can be larger then the type behind mp_digit can hold */
       if ((mid - low) > (unsigned int)(MP_MASK)) {
          err = MP_VAL;
          goto LBL_ERR;
       }
-      if ((err = mp_expt_d(&bi_base, (mid - low), &t)) != MP_OKAY) {
+      if ((err = mp_expt_d(&bi_base, (mp_digit)(mid - low), &t)) != MP_OKAY) {
          goto LBL_ERR;
       }
       if ((err = mp_mul(&bracket_low, &t, &bracket_mid)) != MP_OKAY) {
@@ -161,15 +165,21 @@ int mp_ilogb(mp_int *a, mp_digit base, mp_int *c)
          mp_exch(&bracket_mid, &bracket_low);
       }
       if (cmp == MP_EQ) {
-         mp_set_int(c, (unsigned long)mid);
+         if ((e = mp_set_int(c, (unsigned long)mid)) != MP_OKAY) {
+            goto LTM_ERR;
+         }
          goto LBL_END;
       }
    }
 
    if (mp_cmp(&bracket_high, a) == MP_EQ) {
-      mp_set_int(c, (unsigned long)high);
+      if ((e = mp_set_int(c, (unsigned long)high)) != MP_OKAY) {
+         goto LTM_ERR;
+      }
    } else {
-      mp_set_int(c, (unsigned long)low);
+      if ((e = mp_set_int(c, (unsigned long)low)) != MP_OKAY) {
+         goto LTM_ERR;
+      }
    }
 
 LBL_END: