From d9124ba52e469929d581c3a8166c9e938262f1ef Mon Sep 17 00:00:00 2001 From: Noel Ferreria Date: Thu, 25 Apr 2024 15:58:05 -0700 Subject: [PATCH 1/5] fix workflow and scripts to also not use deprecated set-output --- .github/scripts/check-release.sh | 4 ++-- .github/scripts/source-tag-sha.sh | 2 +- .github/scripts/verify-build.sh | 2 +- .github/workflows/build-release.yaml | 2 +- .github/workflows/major-release.yaml | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/scripts/check-release.sh b/.github/scripts/check-release.sh index 1f43668..2572a71 100755 --- a/.github/scripts/check-release.sh +++ b/.github/scripts/check-release.sh @@ -16,7 +16,7 @@ exists=$( if [[ "$exists" == true ]]; then echo "Release ${release_version} already exists." - echo '::set-output name=release_exists::true' + echo "release_exists=true" >>$GITHUB_ENV else - echo '::set-output name=release_exists::false' + echo "release_exists=false" >>$GITHUB_ENV fi diff --git a/.github/scripts/source-tag-sha.sh b/.github/scripts/source-tag-sha.sh index 6b9119c..9156ed9 100755 --- a/.github/scripts/source-tag-sha.sh +++ b/.github/scripts/source-tag-sha.sh @@ -18,4 +18,4 @@ if [[ $sha == 'null' ]]; then fi echo "SHA for ${tag_name}: ${sha}" -echo "::set-output name=sha::$sha" +echo "sha=${sha}" >>$GITHUB_ENV diff --git a/.github/scripts/verify-build.sh b/.github/scripts/verify-build.sh index ae6b34f..614f1ae 100755 --- a/.github/scripts/verify-build.sh +++ b/.github/scripts/verify-build.sh @@ -6,7 +6,7 @@ git diff git status dist -s -## Raise error if more than 1 files changed in working dir +# Raise error if more than 1 files changed in working dir if [[ ! -z $(git status dist -s) ]]; then echo "Build at dist is outdated. Update build, push and try again." exit 1 diff --git a/.github/workflows/build-release.yaml b/.github/workflows/build-release.yaml index 90e81ad..744fe03 100644 --- a/.github/workflows/build-release.yaml +++ b/.github/workflows/build-release.yaml @@ -46,7 +46,7 @@ jobs: run: | version=$(cat package.json | jq '.version' --raw-output) echo "Version: v${version}" - echo "::set-output name=version::v${version}" + echo "version=v${version}" >> $GITHUB_ENV - name: Check if release exists id: release-check diff --git a/.github/workflows/major-release.yaml b/.github/workflows/major-release.yaml index 73d56ed..8523eb4 100644 --- a/.github/workflows/major-release.yaml +++ b/.github/workflows/major-release.yaml @@ -37,7 +37,7 @@ jobs: echo "Tag name: ${TAG_NAME}" major_version=${TAG_NAME%.*.*} echo "Major Version: ${major_version}" - echo "::set-output name=major_version::$major_version" + echo "major_version=${major_version}" >> $GITHUB_ENV - name: Check if major version exists id: check-release From 7a8a71b4def8631d35b7d687ce1c68133e22da62 Mon Sep 17 00:00:00 2001 From: Noel Ferreria Date: Thu, 25 Apr 2024 16:05:35 -0700 Subject: [PATCH 2/5] bump versions of actions in some workflows --- .github/workflows/build-release.yaml | 2 +- .github/workflows/major-release.yaml | 2 +- .github/workflows/test-branch.yaml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build-release.yaml b/.github/workflows/build-release.yaml index 744fe03..873a0ce 100644 --- a/.github/workflows/build-release.yaml +++ b/.github/workflows/build-release.yaml @@ -39,7 +39,7 @@ jobs: steps: - name: Checkout - uses: actions/checkout@v2 + uses: actions/checkout@v4 - name: Get version id: get-version diff --git a/.github/workflows/major-release.yaml b/.github/workflows/major-release.yaml index 8523eb4..eefd12c 100644 --- a/.github/workflows/major-release.yaml +++ b/.github/workflows/major-release.yaml @@ -29,7 +29,7 @@ jobs: environment: major-release-update steps: - name: Checkout - uses: actions/checkout@v2 + uses: actions/checkout@v4 - name: Get major release version id: get-major-version diff --git a/.github/workflows/test-branch.yaml b/.github/workflows/test-branch.yaml index f7562cc..e208ab0 100644 --- a/.github/workflows/test-branch.yaml +++ b/.github/workflows/test-branch.yaml @@ -16,7 +16,7 @@ jobs: name: Test Linux steps: - name: Checkout - uses: actions/checkout@v2 + uses: actions/checkout@v4 - name: Configure AWS Credentials uses: aws-actions/configure-aws-credentials@v1 with: From 6af5cf97e0a771558d314162063e56cc4da03305 Mon Sep 17 00:00:00 2001 From: Noel Ferreria Date: Thu, 25 Apr 2024 16:24:31 -0700 Subject: [PATCH 3/5] use github outputs context --- .github/scripts/check-release.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/scripts/check-release.sh b/.github/scripts/check-release.sh index 2572a71..527f3de 100755 --- a/.github/scripts/check-release.sh +++ b/.github/scripts/check-release.sh @@ -16,7 +16,7 @@ exists=$( if [[ "$exists" == true ]]; then echo "Release ${release_version} already exists." - echo "release_exists=true" >>$GITHUB_ENV + echo "release_exists=true" >>$GITHUB_OUTPUTS else - echo "release_exists=false" >>$GITHUB_ENV + echo "release_exists=false" >>$GITHUB_OUTPUTS fi From 8a72ad6d66753f77683d183c95a734c05a59ce7c Mon Sep 17 00:00:00 2001 From: Noel Ferreria Date: Thu, 25 Apr 2024 16:34:55 -0700 Subject: [PATCH 4/5] OUTPUT not OUTPUTS --- .github/scripts/check-release.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/scripts/check-release.sh b/.github/scripts/check-release.sh index f43bc17..cad6161 100755 --- a/.github/scripts/check-release.sh +++ b/.github/scripts/check-release.sh @@ -16,8 +16,8 @@ exists=$( if [[ "$exists" == true ]]; then echo "Release ${release_version} already exists." - echo "release_exists=true" >>$GITHUB_OUTPUTS + echo "release_exists=true" >>"$GITHUB_OUTPUT" else - echo "release_exists=false" >>$GITHUB_OUTPUTS + echo "release_exists=false" >>"$GITHUB_OUTPUT" fi From bf1f7982c15076f662cf6b8453e23451cad52866 Mon Sep 17 00:00:00 2001 From: Noel Ferreria Date: Thu, 25 Apr 2024 16:40:05 -0700 Subject: [PATCH 5/5] output wrong for source tag --- .github/scripts/source-tag-sha.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/scripts/source-tag-sha.sh b/.github/scripts/source-tag-sha.sh index 9156ed9..522ed2d 100755 --- a/.github/scripts/source-tag-sha.sh +++ b/.github/scripts/source-tag-sha.sh @@ -18,4 +18,4 @@ if [[ $sha == 'null' ]]; then fi echo "SHA for ${tag_name}: ${sha}" -echo "sha=${sha}" >>$GITHUB_ENV +echo "sha=${sha}" >>"$GITHUB_OUTPUT"