Skip to content

Commit cc246fc

Browse files
stduhpfStéphane du Hamel
authored andcommitted
Tiling: fix edge case
1 parent b406ca6 commit cc246fc

File tree

1 file changed

+17
-9
lines changed

1 file changed

+17
-9
lines changed

ggml_extend.hpp

Lines changed: 17 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -397,7 +397,9 @@ __STATIC_INLINE__ void ggml_merge_tensor_2d(struct ggml_tensor* input,
397397
int x,
398398
int y,
399399
int overlap_x,
400-
int overlap_y) {
400+
int overlap_y,
401+
int x_skip = 0,
402+
int y_skip = 0) {
401403
int64_t width = input->ne[0];
402404
int64_t height = input->ne[1];
403405
int64_t channels = input->ne[2];
@@ -406,16 +408,16 @@ __STATIC_INLINE__ void ggml_merge_tensor_2d(struct ggml_tensor* input,
406408
int64_t img_height = output->ne[1];
407409

408410
GGML_ASSERT(input->type == GGML_TYPE_F32 && output->type == GGML_TYPE_F32);
409-
for (int iy = 0; iy < height; iy++) {
410-
for (int ix = 0; ix < width; ix++) {
411+
for (int iy = y_skip; iy < height; iy++) {
412+
for (int ix = x_skip; ix < width; ix++) {
411413
for (int k = 0; k < channels; k++) {
412414
float new_value = ggml_tensor_get_f32(input, ix, iy, k);
413415
if (overlap_x > 0 && overlap_y > 0) { // blend colors in overlapped area
414416
float old_value = ggml_tensor_get_f32(output, x + ix, y + iy, k);
415417

416-
const float x_f_0 = (overlap_x > 0 && x > 0) ? ix / float(overlap_x) : 1;
418+
const float x_f_0 = (overlap_x > 0 && x > 0) ? (ix - x_skip) / float(overlap_x) : 1;
417419
const float x_f_1 = (overlap_x > 0 && x < (img_width - width)) ? (width - ix) / float(overlap_x) : 1;
418-
const float y_f_0 = (overlap_y > 0 && y > 0) ? iy / float(overlap_y) : 1;
420+
const float y_f_0 = (overlap_y > 0 && y > 0) ? (iy - y_skip) / float(overlap_y) : 1;
419421
const float y_f_1 = (overlap_y > 0 && y < (img_height - height)) ? (height - iy) / float(overlap_y) : 1;
420422

421423
const float x_f = std::min(std::min(x_f_0, x_f_1), 1.f);
@@ -544,10 +546,10 @@ __STATIC_INLINE__ void sd_tiling(ggml_tensor* input, ggml_tensor* output, const
544546
input_tile_size = tile_size * scale;
545547
output_tile_size = tile_size;
546548
}
547-
int num_tiles_x = (float)(input_width - input_tile_size * tile_overlap_factor) / (float)(input_tile_size * (1 - tile_overlap_factor));
549+
int num_tiles_x = (input_width - (int)(input_tile_size * tile_overlap_factor)) / (int)(input_tile_size * (1 - tile_overlap_factor));
548550
float tile_overlap_factor_x = (float)(input_tile_size * num_tiles_x - input_width) / (float)(input_tile_size * (num_tiles_x - 1));
549551

550-
int num_tiles_y = (float)(input_height - input_tile_size * tile_overlap_factor) / (float)(input_tile_size * (1 - tile_overlap_factor));
552+
int num_tiles_y = (input_height - (int)(input_tile_size * tile_overlap_factor)) / (int)(input_tile_size * (1 - tile_overlap_factor));
551553
float tile_overlap_factor_y = (float)(input_tile_size * num_tiles_y - input_height) / (float)(input_tile_size * (num_tiles_y - 1));
552554

553555
LOG_DEBUG("optimal overlap : %f, %f (targeting %f)", tile_overlap_factor_x, tile_overlap_factor_y, tile_overlap_factor);
@@ -587,22 +589,28 @@ __STATIC_INLINE__ void sd_tiling(ggml_tensor* input, ggml_tensor* output, const
587589
bool last_y = false, last_x = false;
588590
float last_time = 0.0f;
589591
for (int y = 0; y < input_height && !last_y; y += non_tile_overlap_y) {
592+
int dy = 0;
590593
if (y + input_tile_size >= input_height) {
594+
int _y = y;
591595
y = input_height - input_tile_size;
596+
dy = _y - y;
592597
last_y = true;
593598
}
594599
for (int x = 0; x < input_width && !last_x; x += non_tile_overlap_x) {
600+
int dx = 0;
595601
if (x + input_tile_size >= input_width) {
602+
int _x = x;
596603
x = input_width - input_tile_size;
604+
dx = _x - x;
597605
last_x = true;
598606
}
599607
int64_t t1 = ggml_time_ms();
600608
ggml_split_tensor_2d(input, input_tile, x, y);
601609
on_processing(input_tile, output_tile, false);
602610
if (scaled_out) {
603-
ggml_merge_tensor_2d(output_tile, output, x * scale, y * scale, tile_overlap_x * scale, tile_overlap_y * scale);
611+
ggml_merge_tensor_2d(output_tile, output, x * scale, y * scale, tile_overlap_x * scale, tile_overlap_y * scale, dx * scale, dy * scale);
604612
} else {
605-
ggml_merge_tensor_2d(output_tile, output, x / scale, y / scale, tile_overlap_x / scale, tile_overlap_y / scale);
613+
ggml_merge_tensor_2d(output_tile, output, x / scale, y / scale, tile_overlap_x / scale, tile_overlap_y / scale, dx / scale, dy / scale);
606614
}
607615
int64_t t2 = ggml_time_ms();
608616
last_time = (t2 - t1) / 1000.0f;

0 commit comments

Comments
 (0)