Skip to content

Commit 21fc3f0

Browse files
committed
Tiling: fix edge cases for adaptative overlap
1 parent a869bcb commit 21fc3f0

File tree

1 file changed

+23
-4
lines changed

1 file changed

+23
-4
lines changed

ggml_extend.hpp

Lines changed: 23 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -753,9 +753,20 @@ __STATIC_INLINE__ void sd_tiling(ggml_tensor* input, ggml_tensor* output, const
753753
input_tile_size = tile_size * scale;
754754
output_tile_size = tile_size;
755755
}
756-
int num_tiles_x = (input_width - (int)(input_tile_size * tile_overlap_factor)) / (int)(input_tile_size * (1 - tile_overlap_factor));
756+
int tile_overlap = (input_tile_size * tile_overlap_factor);
757+
int non_tile_overlap = input_tile_size - tile_overlap;
758+
759+
int num_tiles_x = (input_width - tile_overlap) / non_tile_overlap;
760+
int overshoot_x = ((num_tiles_x + 1) * non_tile_overlap + tile_overlap) % input_width;
761+
762+
if ((overshoot_x != non_tile_overlap) && (overshoot_x <= num_tiles_x * (input_tile_size / 2 - tile_overlap))) {
763+
// if tiles don't fit perfectly using the desired overlap
764+
// and there is enough room to squeeze an extra tile without overlap becoming >0.5
765+
num_tiles_x++;
766+
}
767+
757768
float tile_overlap_factor_x = (float)(input_tile_size * num_tiles_x - input_width) / (float)(input_tile_size * (num_tiles_x - 1));
758-
if (num_tiles_x <= 1) {
769+
if (num_tiles_x <= 2) {
759770
if (input_width == input_tile_size) {
760771
num_tiles_x = 1;
761772
tile_overlap_factor_x = 0;
@@ -765,9 +776,17 @@ __STATIC_INLINE__ void sd_tiling(ggml_tensor* input, ggml_tensor* output, const
765776
}
766777
}
767778

768-
int num_tiles_y = (input_height - (int)(input_tile_size * tile_overlap_factor)) / (int)(input_tile_size * (1 - tile_overlap_factor));
779+
int num_tiles_y = (input_height - tile_overlap) / non_tile_overlap;
780+
int overshoot_y = ((num_tiles_y + 1) * non_tile_overlap + tile_overlap) % input_height;
781+
782+
if ((overshoot_y != non_tile_overlap) && (overshoot_y <= num_tiles_y * (input_tile_size / 2 - tile_overlap))) {
783+
// if tiles don't fit perfectly using the desired overlap
784+
// and there is enough room to squeeze an extra tile without overlap becoming >0.5
785+
num_tiles_y++;
786+
}
787+
769788
float tile_overlap_factor_y = (float)(input_tile_size * num_tiles_y - input_height) / (float)(input_tile_size * (num_tiles_y - 1));
770-
if (num_tiles_y <= 1) {
789+
if (num_tiles_y <= 2) {
771790
if (input_height == input_tile_size) {
772791
num_tiles_y = 1;
773792
tile_overlap_factor_y = 0;

0 commit comments

Comments
 (0)