From 824133a7dcecdbe5c7322efaae35f1f6dcd96a50 Mon Sep 17 00:00:00 2001 From: Ed Costello Date: Fri, 19 Mar 2021 17:27:10 +1300 Subject: [PATCH] fix: start background thread for identify rather than running it The identify call is running the identify code synchronously instead of starting the background thread. This results in it blocking the calling JavaScript thread, essentially making it a synchronous call even though it's returning an asynchronous promise. This fixes the typo so we start the thread which SHOULD make this non-blocking for the calling react native app. --- .../reactnative/LaunchdarklyReactNativeClientModule.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/android/src/main/java/com/launchdarkly/reactnative/LaunchdarklyReactNativeClientModule.java b/android/src/main/java/com/launchdarkly/reactnative/LaunchdarklyReactNativeClientModule.java index ccb0a15..7963867 100644 --- a/android/src/main/java/com/launchdarkly/reactnative/LaunchdarklyReactNativeClientModule.java +++ b/android/src/main/java/com/launchdarkly/reactnative/LaunchdarklyReactNativeClientModule.java @@ -989,7 +989,7 @@ public void run() { } } }); - background.run(); + background.start(); } @ReactMethod