(U2C 4) remove deprecated things (#192)

Author: eli-darkly

docs/api-deprecated.rst

@@ -20,4 +20,3 @@ For more information, see LaunchDarkly's `Quickstart <https://docs.launchdarkly.
    api-integrations
    api-extending
    api-testing
-   api-deprecated

docs/index.rst

@@ -253,7 +253,7 @@ def variation(self, key: str, user: dict, default: Any) -> Any:
     def variation_detail(self, key: str, user: dict, default: Any) -> EvaluationDetail:
         """Determines the variation of a feature flag for a user, like :func:`variation()`, but also
         provides additional information about how this value was calculated, in the form of an
-        :class:`ldclient.flag.EvaluationDetail` object.
+        :class:`ldclient.evaluation.EvaluationDetail` object.
 
         Calling this method also causes the "reason" data to be included in analytics events,
         if you are capturing detailed event data for this flag.

ldclient/client.py

@@ -9,7 +9,7 @@
 from typing import Callable, Optional, Tuple
 
 # For consistency with past logging behavior, we are pretending that the evaluation logic still lives in
-# the ldclient.flag module.
+# the ldclient.evaluation module.
 log = logging.getLogger('ldclient.flag')
 
 __LONG_SCALE__ = float(0xFFFFFFFFFFFFFFF)

ldclient/flag.py

@@ -161,24 +161,12 @@ def new_feature_store(url: str='redis://localhost:6379/0',
         :param url: the URL of the Redis host; defaults to ``DEFAULT_URL``
         :param prefix: a namespace prefix to be prepended to all Redis keys; defaults to
           ``DEFAULT_PREFIX``
-        :param max_connections: the maximum number of Redis connections to keep in the
-          connection pool; defaults to ``DEFAULT_MAX_CONNECTIONS``. This
-          parameter will later be dropped in favor of setting
-          redis_opts['max_connections']
         :param caching: specifies whether local caching should be enabled and if so,
           sets the cache properties; defaults to :func:`ldclient.feature_store.CacheConfig.default()`
         :param redis_opts: extra options for initializing Redis connection from the url,
-          see `redis.connection.ConnectionPool.from_url` for more details. Note that
-          if you set max_connections, this will take precedence over the
-          deprecated max_connections parameter.
+          see `redis.connection.ConnectionPool.from_url` for more details.
         """
 
-        # WARN(deprecated): Remove the max_connection parameter from
-        # this signature and clean up this bit of code.
-        if 'max_connections' not in redis_opts:
-            redis_opts = redis_opts.copy()
-            redis_opts['max_connections'] = max_connections
-
         core = _RedisFeatureStoreCore(url, prefix, redis_opts)
         wrapper = CachingStoreWrapper(core, caching)
         wrapper._core = core  # exposed for testing
@@ -208,22 +196,10 @@ def new_big_segment_store(url: str='redis://localhost:6379/0',
         :param url: the URL of the Redis host; defaults to ``DEFAULT_URL``
         :param prefix: a namespace prefix to be prepended to all Redis keys; defaults to
           ``DEFAULT_PREFIX``
-        :param max_connections: the maximum number of Redis connections to keep in the
-          connection pool; defaults to ``DEFAULT_MAX_CONNECTIONS``. This
-          parameter will later be dropped in favor of setting
-          redis_opts['max_connections']
         :param redis_opts: extra options for initializing Redis connection from the url,
-          see `redis.connection.ConnectionPool.from_url` for more details. Note that
-          if you set max_connections, this will take precedence over the
-          deprecated max_connections parameter.
+          see `redis.connection.ConnectionPool.from_url` for more details.
         """
 
-        # WARN(deprecated): Remove the max_connection parameter from
-        # this signature and clean up this bit of code.
-        if 'max_connections' not in redis_opts:
-            redis_opts = redis_opts.copy()
-            redis_opts['max_connections'] = max_connections
-
         return _RedisBigSegmentStore(url, prefix, redis_opts)
 
 class Files:

ldclient/flags_state.py

@@ -341,7 +341,7 @@ def available(self) -> bool:
     
         If this property is False, the store is not able to make queries (for instance, it may not have
         a valid database connection). In this case, the SDK will treat any reference to a Big Segment
-        as if no users are included in that segment. Also, the :func:`ldclient.flag.EvaluationDetail.reason`
+        as if no users are included in that segment. Also, the :func:`ldclient.evaluation.EvaluationDetail.reason`
         associated with with any flag evaluation that references a Big Segment when the store is not
         available will have a `bigSegmentsStatus` of `"STORE_ERROR"`.
         """
@@ -356,7 +356,7 @@ def stale(self) -> bool:
         This may indicate that the LaunchDarkly Relay Proxy, which populates the store, has stopped
         running or has become unable to receive fresh data from LaunchDarkly. Any feature flag
         evaluations that reference a Big Segment will be using the last known data, which may be out
-        of date. Also, the :func:`ldclient.flag.EvaluationDetail.reason` associated with those evaluations
+        of date. Also, the :func:`ldclient.evaluation.EvaluationDetail.reason` associated with those evaluations
         will have a `bigSegmentsStatus` of `"STALE"`.
         """
         return self.__stale