Merge pull request #104 from launchdarkly/eb/fix-tests

miscellaneous test fixes

Author: eli-darkly

ldclient/client.py

@@ -124,7 +124,7 @@ def _make_event_processor(self, config):
     def _make_update_processor(self, config, store, ready):
         if config.update_processor_class:
             log.info("Using user-specified update processor: " + str(config.update_processor_class))
-            return self._config.update_processor_class(config, store, ready)
+            return config.update_processor_class(config, store, ready)
 
         if config.offline or config.use_ldd:
             return NullUpdateProcessor(config, store, ready)

testing/test_ldclient.py

@@ -111,12 +111,14 @@ def test_client_has_null_update_processor_in_ldd_mode():
         assert isinstance(client._update_processor, NullUpdateProcessor)
 
 
+@pytest.mark.skip("Can't currently use a live stream processor in tests because its error logging will disrupt other tests.")
 def test_client_has_streaming_processor_by_default():
     config = Config(sdk_key="secret", base_uri=unreachable_uri, stream_uri=unreachable_uri, send_events=False)
     with LDClient(config=config, start_wait=0) as client:
         assert isinstance(client._update_processor, StreamingUpdateProcessor)
 
 
+@pytest.mark.skip("Can't currently use a live polling processor in tests because its error logging will disrupt other tests.")
 def test_client_has_polling_processor_if_streaming_is_disabled():
     config = Config(sdk_key="secret", stream=False, base_uri=unreachable_uri, stream_uri=unreachable_uri, send_events=False)
     with LDClient(config=config, start_wait=0) as client:

testing/test_ldclient_evaluation.py

@@ -123,7 +123,7 @@ def test_variation_detail_when_user_is_none():
     expected = EvaluationDetail('default', None, {'kind': 'ERROR', 'errorKind': 'USER_NOT_SPECIFIED'})
     assert expected == client.variation_detail('feature.key', None, default='default')
 
-def test_variation_when_user_has_no_key():
+def test_variation_detail_when_user_has_no_key():
     feature = make_off_flag_with_value('feature.key', 'value')
     store = InMemoryFeatureStore()
     store.init({FEATURES: {'feature.key': feature}})