From 551d84ca5ec9cf547ef6c0281417adc7563fb8d8 Mon Sep 17 00:00:00 2001 From: Max Lund Date: Fri, 8 Dec 2017 11:47:49 -0600 Subject: [PATCH 1/2] allow integer values to be used for bucketing --- src/LaunchDarkly/VariationOrRollout.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/LaunchDarkly/VariationOrRollout.php b/src/LaunchDarkly/VariationOrRollout.php index e1ff63b60..95e96ae97 100644 --- a/src/LaunchDarkly/VariationOrRollout.php +++ b/src/LaunchDarkly/VariationOrRollout.php @@ -72,6 +72,9 @@ private function bucketUser($user, $_key, $attr, $_salt) { $userValue = $user->getValueForEvaluation($attr); $idHash = null; if ($userValue != null) { + if (is_int($userValue)) { + $userValue = (string)$userValue; + } if (is_string($userValue)) { $idHash = $userValue; if ($user->getSecondary() !== null) { From 113a2a5db5c294b498ceba0cb418d848c6cda2d7 Mon Sep 17 00:00:00 2001 From: Max Lund Date: Fri, 8 Dec 2017 12:16:35 -0600 Subject: [PATCH 2/2] format --- src/LaunchDarkly/VariationOrRollout.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/LaunchDarkly/VariationOrRollout.php b/src/LaunchDarkly/VariationOrRollout.php index 95e96ae97..b605ad02f 100644 --- a/src/LaunchDarkly/VariationOrRollout.php +++ b/src/LaunchDarkly/VariationOrRollout.php @@ -73,7 +73,7 @@ private function bucketUser($user, $_key, $attr, $_salt) { $idHash = null; if ($userValue != null) { if (is_int($userValue)) { - $userValue = (string)$userValue; + $userValue = (string) $userValue; } if (is_string($userValue)) { $idHash = $userValue;