Skip to content

TTL : Allow different cache strategy (exemple: greedyCacheStrategy) #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

TTL : Allow different cache strategy (exemple: greedyCacheStrategy) #137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/LaunchDarkly/Impl/Integrations/GuzzleFeatureRequester.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
use GuzzleHttp\Exception\BadResponseException;
use GuzzleHttp\HandlerStack;
use Kevinrob\GuzzleCache\CacheMiddleware;
use Kevinrob\GuzzleCache\Strategy\CacheStrategyInterface;
use Kevinrob\GuzzleCache\Strategy\PublicCacheStrategy;
use LaunchDarkly\FeatureFlag;
use LaunchDarkly\FeatureRequester;
Expand Down Expand Up @@ -35,7 +36,10 @@ public function __construct($baseUri, $sdkKey, $options)
$this->_logger = $options['logger'];
$stack = HandlerStack::create();
if (class_exists('Kevinrob\GuzzleCache\CacheMiddleware')) {
$stack->push(new CacheMiddleware(new PublicCacheStrategy(isset($options['cache']) ? $options['cache'] : null)), 'cache');
$cacheOption = isset($options['cache']) ? $options['cache'] : null;
$cacheOption instanceof CacheStrategyInterface
? $stack->push(new CacheMiddleware($cacheOption), 'cache')
: $stack->push(new CacheMiddleware(new PublicCacheStrategy($cacheOption)), 'cache');
} elseif (!$this->_loggedCacheNotice) {
$this->_logger->info("GuzzleFeatureRequester is not using an HTTP cache because Kevinrob\GuzzleCache\CacheMiddleware was not installed");
$this->_loggedCacheNotice = true;
Expand Down