fix test to fill in all required flag fields

Author: eli-darkly

tests/LDClientTest.php

@@ -166,14 +166,19 @@ public function testAllFlagsStateReturnsState()
 
     public function testAllFlagsStateCanFilterForClientSideFlags()
     {
-        $flag1Json = array('key' => 'server-side-1', 'on' => false, 'offVariation' => 0, 'variations' => array('a'), 'clientSide' => false);
-        $flag1 = FeatureFlag::decode($flag1Json);
-        $flag2Json = array('key' => 'server-side-2', 'on' => false, 'offVariation' => 0, 'variations' => array('b'), 'clientSide' => false);
-        $flag2 = FeatureFlag::decode($flag2Json);
-        $flag3Json = array('key' => 'client-side-1', 'on' => false, 'offVariation' => 0, 'variations' => array('value1'), 'clientSide' => true);
-        $flag3 = FeatureFlag::decode($flag3Json);
-        $flag4Json = array('key' => 'client-side-2', 'on' => false, 'offVariation' => 0, 'variations' => array('value2'), 'clientSide' => true);
-        $flag4 = FeatureFlag::decode($flag4Json);
+        $flagJson = array('key' => 'server-side-1', 'version' => 1, 'on' => false, 'salt' => '', 'deleted' => false,
+            'targets' => array(), 'rules' => array(), 'prerequisites' => array(), 'fallthrough' => array(),
+            'offVariation' => 0, 'variations' => array('a'), 'clientSide' => false);
+        $flag1 = FeatureFlag::decode($flagJson);
+        $flagJson['key'] = 'server-side-2';
+        $flag2 = FeatureFlag::decode($flagJson);
+        $flagJson['key'] = 'client-side-1';
+        $flagJson['clientSide'] = true;
+        $flagJson['variations'] = array('value1');
+        $flag3 = FeatureFlag::decode($flagJson);
+        $flagJson['key'] = 'client-side-2';
+        $flagJson['variations'] = array('value2');
+        $flag4 = FeatureFlag::decode($flagJson);
         MockFeatureRequester::$flags = array(
             $flag1->getKey() => $flag1, $flag2->getKey() => $flag2, $flag3->getKey() => $flag3, $flag4->getKey() => $flag4
         );