Skip to content

Commit e067d0b

Browse files
authored
Merge pull request #35 from launchdarkly/dr/allowBlankUserKey
Allow blank user key in evaluation.
2 parents 897e0d6 + 329b574 commit e067d0b

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

src/LaunchDarkly/LDClient.php

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,11 +111,14 @@ public function variation($key, $user, $default = false) {
111111
}
112112

113113
try {
114-
if (is_null($user) || strlen($user->getKey()) === 0) {
114+
if (is_null($user) || is_null($user->getKey()) ) {
115115
$this->_sendFlagRequestEvent($key, $user, $default, $default);
116-
$this->_logger->warn("Variation called with null user or null/empty user key! Returning default value");
116+
$this->_logger->warn("Variation called with null user or null user key! Returning default value");
117117
return $default;
118118
}
119+
if (strlen($user->getKey()) === 0) {
120+
$this->_logger->warn("User key is blank. Flag evaluation will proceed, but the user will not be stored in LaunchDarkly.");
121+
}
119122
$flag = $this->_featureRequester->get($key);
120123

121124
if (is_null($flag)) {

0 commit comments

Comments
 (0)