remove alias events (#101)

Author: eli-darkly

Makefile

@@ -6,13 +6,9 @@ TEMP_TEST_OUTPUT=/tmp/sse-contract-test-service.log
 # - "secondary": In the PHP SDK this is not an addressable attribute for clauses; in other
 #   SDKs, it is. This was underspecified in the past; in future major versions, the other
 #   SDKs and the contract tests will be in line with the PHP behavior.
-# - "date - bad syntax", "semver - bad type": The PHP SDK has insufficiently strict
-#   validation for these types. We will definitely fix this in 5.0 but may or may not
-#   address it in 4.x, since it does not prevent any valid values from working.
 TEST_HARNESS_PARAMS := $(TEST_HARNESS_PARAMS) \
 	-skip 'evaluation/parameterized/secondary' \
-	-skip 'evaluation/parameterized/operators - date - bad syntax' \
-	-skip 'evaluation/parameterized/operators - semver - bad type'
+	-skip 'events/alias'
 
 build-contract-tests:
 	@cd test-service && composer install --no-progress

src/LaunchDarkly/Impl/Events/EventFactory.php

@@ -160,23 +160,6 @@ public function newCustomEvent(string $eventName, LDUser $user, $data, $metricVa
         return $e;
     }
 
-    /**
-     * @return (mixed|null)[]
-     */
-    public function newAliasEvent(LDUser $user, LDUser $previousUser): array
-    {
-        $e = [
-            'kind' => 'alias',
-            'key' => strval($user->getKey()),
-            'contextKind' => static::contextKind($user),
-            'previousKey' => strval($previousUser->getKey()),
-            'previousContextKind' => static::contextKind($previousUser),
-            'creationDate' => Util::currentTimeUnixMillis()
-        ];
-
-        return $e;
-    }
-
     private static function contextKind(LDUser $user): string
     {
         if ($user->getAnonymous()) {

src/LaunchDarkly/LDClient.php

@@ -385,33 +385,6 @@ public function allFlagsState(LDUser $user, array $options = []): FeatureFlagsSt
         return $state;
     }
 
-    /**
-     * Associates two users for analytics purposes.
-     *
-     * This can be helpful in the situation where a person is represented by multiple
-     * LaunchDarkly users. This may happen, for example, when a person initially logs into
-     * an application-- the person might be represented by an anonymous user prior to logging
-     * in and a different user after logging in, as denoted by a different user key.
-     *
-     * @param LDUser $user the newly identified user.
-     * @param LDUser $previousUser the previously identified user.
-     */
-    public function alias(LDUser $user, LDUser $previousUser): void
-    {
-        if (is_null($user->getKey())) {
-            $this->_logger->warning("Alias called with null/empty user!");
-            return;
-        }
-
-        if (is_null($previousUser->getKey())) {
-            $this->_logger->warning("Alias called with null/empty previousUser!");
-            return;
-        }
-
-        $event = $this->_eventFactoryDefault->newAliasEvent($user, $previousUser);
-        $this->_eventProcessor->enqueue($event);
-    }
-
     /**
      * Generates an HMAC sha256 hash for use in Secure mode.
      *

test-service/SdkClientEntity.php

@@ -53,10 +53,6 @@ public function doCommand($reqParams)
         $command = $reqParams['command'];
         $commandParams = $reqParams[$command] ?? null;
         switch ($command) {
-            case 'aliasEvent':
-                $this->doAliasEvent($commandParams);
-                return null;
-
             case 'customEvent':
                 $this->doCustomEvent($commandParams);
                 return null;
@@ -83,14 +79,6 @@ public function doCommand($reqParams)
         }
     }
 
-    private function doAliasEvent($params)
-    {
-        $this->_client->alias(
-            $this->makeUser($params['user']),
-            $this->makeUser($params['previousUser'])
-        );
-    }
-
     private function doCustomEvent($params)
     {
         $this->_client->track(

tests/LDClientTest.php

@@ -651,30 +651,6 @@ public function testTrackWithAnonymousUserSendsEventWithAnonymousContextKind()
         $this->assertEquals('anonymousUser', $event['contextKind']);
     }
 
-    public function testAliasEventsAreCorrect()
-    {
-        $ep = new MockEventProcessor();
-        $client = $this->makeClient(['event_processor' => $ep]);
-
-        $user_builder = new LDUserBuilder("[email protected]");
-        $user = $user_builder->anonymous(false)->build();
-        $anon_builder = new LDUserBuilder("[email protected]");
-        $anon = $anon_builder->anonymous(true)->build();
-
-        $client->alias($user, $anon);
-
-        $queue = $ep->getEvents();
-        $this->assertEquals(1, sizeof($queue));
-
-        $event = $queue[0];
-
-        $this->assertEquals('alias', $event['kind']);
-        $this->assertEquals($user->getKey(), $event['key']);
-        $this->assertEquals('user', $event['contextKind']);
-        $this->assertEquals($anon->getKey(), $event['previousKey']);
-        $this->assertEquals('anonymousUser', $event['previousContextKind']);
-    }
-
     public function testEventsAreNotPublishedIfSendEventsIsFalse()
     {
         // In order to do this test, we cannot provide a mock object for Event_Processor_,