Skip to content

Commit 87f37d4

Browse files
author
Dan Richelson
committed
add better check for blank user key
1 parent 98e55f1 commit 87f37d4

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/LaunchDarkly/LDClient.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ public function variation($key, $user, $default = false) {
111111
}
112112

113113
try {
114-
if (is_null($user) || $user->getKey() === null ) {
114+
if (is_null($user) || is_null($user->getKey())) {
115115
$this->_sendFlagRequestEvent($key, $user, $default, $default);
116116
$this->_logger->warn("Variation called with null user or null user key! Returning default value");
117117
return $default;

tests/LDUserTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,7 @@ public function testLDUserBlankKey() {
105105
$builder = new LDUserBuilder("");
106106
$user = $builder->build();
107107
$this->assertTrue($user->isKeyBlank());
108+
$this->assertFalse(is_null($user->getKey()));
108109

109110
$builder = new LDUserBuilder("key");
110111
$user = $builder->build();
@@ -113,7 +114,6 @@ public function testLDUserBlankKey() {
113114
$builder = new LDUserBuilder(null);
114115
$user = $builder->build();
115116
$this->assertFalse($user->isKeyBlank());
116-
117117
}
118118
}
119119

0 commit comments

Comments
 (0)