Don't return custom attributes as json array. (#14)

By not sending the 'custom' attribute when it is empty, we don't have to deal
with trying to return an object rather than array.

Author: ashanbrown

src/LaunchDarkly/EventSerializer.php

@@ -70,7 +70,9 @@ private function serializeUser($user) {
         if (!empty($user->getCustom())) {
             $customs = array();
             $this->filterAttrs($user->getCustom(), $customs, $userPrivateAttrs, $allPrivateAttrs);
-            $json['custom'] = $customs;
+            if ($customs) { // if this is empty, we will return a json array for 'custom' instead of an object
+                $json['custom'] = $customs;
+            }
         }
         if (count($allPrivateAttrs)) {
             $pa = array_keys($allPrivateAttrs);

tests/EventSerializerTest.php

@@ -32,7 +32,6 @@ private function getFullUserResult() {
     private function getUserResultWithAllAttrsHidden() {
         return array(
             'key' => 'abc',
-            'custom' => array(),
             'privateAttrs' => array('bizzle', 'dizzle', 'firstName')
         );
     }
@@ -122,7 +121,14 @@ public function testEmptyCustom() {
         $json = $this->getJsonForUserBySerializingEvent($user);
         $this->assertFalse(isset($json['custom']));
     }
-    
+
+    public function testEmptyPrivateCustom() {
+        $builder = new LDUserBuilder("[email protected]");
+        $user = $builder->privateCustomAttribute("my-key", "my-value")->build();
+        $json = $this->getJsonForUserBySerializingEvent($user);
+        $this->assertFalse(isset($json['custom']));
+    }
+
     public function testUserSecondary() {
         $builder = new LDUserBuilder("[email protected]");
         $user = $builder->secondary("secondary")->build();