Merge pull request #102 from localheinz/fix/risky

Fix: Risky tests

Author: eli-darkly

phpunit.xml

@@ -2,6 +2,13 @@
     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
     xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd"
     bootstrap="vendor/autoload.php"
+    colors="true"
+    beStrictAboutChangesToGlobalState="true"
+    beStrictAboutOutputDuringTests="true"
+    beStrictAboutResourceUsageDuringSmallTests="true"
+    beStrictAboutTestsThatDoNotTestAnything="true"
+    beStrictAboutTodoAnnotatedTests="true"
+    verbose="true"
 >
     <testsuites>
         <testsuite name="Unit Tests">

tests/FeatureFlagTest.php

@@ -142,8 +142,8 @@ class FeatureFlagTest extends \PHPUnit_Framework_TestCase
 
     public function testDecode()
     {
-        FeatureFlag::decode(\GuzzleHttp\json_decode(FeatureFlagTest::$json1, true));
-        FeatureFlag::decode(\GuzzleHttp\json_decode(FeatureFlagTest::$json2, true));
+        $this->assertInstanceOf(FeatureFlag::class, FeatureFlag::decode(\GuzzleHttp\json_decode(FeatureFlagTest::$json1, true)));
+        $this->assertInstanceOf(FeatureFlag::class, FeatureFlag::decode(\GuzzleHttp\json_decode(FeatureFlagTest::$json2, true)));
     }
 
     public function dataDecodeMulti()

tests/LDClientTest.php

@@ -14,7 +14,7 @@ class LDClientTest extends \PHPUnit_Framework_TestCase
 
     public function testDefaultCtor()
     {
-        new LDClient("BOGUS_SDK_KEY");
+        $this->assertInstanceOf(LDClient::class, new LDClient("BOGUS_SDK_KEY"));
     }
 
     public function testToggleDefault()

tests/LDUserTest.php

@@ -1,6 +1,7 @@
 <?php
 namespace LaunchDarkly\Tests;
 
+use LaunchDarkly\LDUser;
 use LaunchDarkly\LDUserBuilder;
 
 class LDUserTest extends \PHPUnit_Framework_TestCase
@@ -23,7 +24,10 @@ public function testCoerceLDUserKey()
     public function testEmptyCustom()
     {        
         $builder = new LDUserBuilder("[email protected]");
+        
         $user = $builder->build();
+        
+        $this->assertInstanceOf(LDUser::class, $user);
     }
 
     public function testLDUserSecondary()

tests/SemanticVersionTest.php

@@ -47,32 +47,31 @@ public function testCanParseVersionWithPrereleaseAndBuild()
         $this->assertEquals('build2.4', $sv->build);
     }
 
+    /**
+     * @expectedException \InvalidArgumentException
+     * @expectedExceptionMessage not a valid semantic version
+     */
     public function testLeadingZeroNotAllowedInMajor()
     {
-        try {
-            SemanticVersion::parse('02.3.4');
-            $this->assertTrue(false, 'expected exception');
-            // can't use expectException method because we must support older PHPUnit
-        } catch (\InvalidArgumentException $e) {
-        }
+        SemanticVersion::parse('02.3.4');
     }
 
+    /**
+     * @expectedException \InvalidArgumentException
+     * @expectedExceptionMessage not a valid semantic version
+     */
     public function testLeadingZeroNotAllowedInMinor()
     {
-        try {
-            SemanticVersion::parse('2.03.4');
-            $this->assertTrue(false, 'expected exception');
-        } catch (\InvalidArgumentException $e) {
-        }
+        SemanticVersion::parse('2.03.4');
     }
 
+    /**
+     * @expectedException \InvalidArgumentException
+     * @expectedExceptionMessage not a valid semantic version
+     */
     public function testLeadingZeroNotAllowedInPatch()
     {
-        try {
-            SemanticVersion::parse('2.3.04');
-            $this->assertTrue(false, 'expected exception');
-        } catch (\InvalidArgumentException $e) {
-        }
+        SemanticVersion::parse('2.3.04');
     }
 
     public function testZeroByItselfIsAllowed()
@@ -147,22 +146,22 @@ public function testCanParseVersionWithMajorMinorAndBuildOnlyInLooseMode()
         $this->assertEquals('build1', $sv->build);
     }
 
+    /**
+     * @expectedException \InvalidArgumentException
+     * @expectedExceptionMessage not a valid semantic version
+     */
     public function testCannotParseVersionWithMajorOnlyByDefault()
     {
-        try {
-            SemanticVersion::parse('2');
-            $this->assertTrue(false, 'expected exception');
-        } catch (\InvalidArgumentException $e) {
-        }
+        SemanticVersion::parse('2');
     }
 
+    /**
+     * @expectedException \InvalidArgumentException
+     * @expectedExceptionMessage not a valid semantic version
+     */
     public function testCannotParseVersionWithMajorAndMinorOnlyByDefault()
     {
-        try {
-            SemanticVersion::parse('2.3');
-            $this->assertTrue(false, 'expected exception');
-        } catch (\InvalidArgumentException $e) {
-        }
+        SemanticVersion::parse('2.3');
     }
 
     public function testEqualVersionsHaveEqualPrecedence()