minor cleanup

eli-darkly · eli-darkly · commit 679e5ca67536 · 2020-01-02T19:12:42.000-08:00
diff --git a/src/LaunchDarkly/VariationOrRollout.php b/src/LaunchDarkly/VariationOrRollout.php
@@ -54,11 +54,11 @@ public function variationIndexForUser($user, $_key, $_salt)
             return $this->_variation;
         }
         $rollout = $this->_rollout;
-        if ($rollout == null) {
+        if ($rollout === null) {
             return null;
         }
         $variations = $rollout->getVariations();
-        if ($variations != null && count($variations) > 0) {
+        if ($variations) {
             $bucketBy = $this->_rollout->getBucketBy() === null ? "key" : $this->_rollout->getBucketBy();
             $bucket = self::bucketUser($user, $_key, $bucketBy, $_salt);
             $sum = 0.0;

Original file line number	Diff line number	Diff line change
`@@ -54,11 +54,11 @@ public function variationIndexForUser($user, $_key, $_salt)`
`54`	`54`	`return $this->_variation;`
`55`	`55`	`}`
`56`	`56`	`$rollout = $this->_rollout;`
`57`		`- if ($rollout == null) {`
	`57`	`+ if ($rollout === null) {`
`58`	`58`	`return null;`
`59`	`59`	`}`
`60`	`60`	`$variations = $rollout->getVariations();`
`61`		`- if ($variations != null && count($variations) > 0) {`
	`61`	`+ if ($variations) {`
`62`	`62`	`$bucketBy = $this->_rollout->getBucketBy() === null ? "key" : $this->_rollout->getBucketBy();`
`63`	`63`	`$bucket = self::bucketUser($user, $_key, $bucketBy, $_salt);`
`64`	`64`	`$sum = 0.0;`