Merge pull request #9 from eplusminus/eb/stop-on-401

stop trying to do HTTP after we get a 401

Author: arun251

src/LaunchDarkly/EventPublisher.php

@@ -18,4 +18,4 @@ public function __construct($sdkKey, array $options);
      * @return bool Whether the events were successfully published
      */
     public function publish($payload);
-}
+}

src/LaunchDarkly/GuzzleEventPublisher.php

@@ -47,16 +47,19 @@ function __construct($sdkKey, array $options = array()) {
 
     public function publish($payload) {
         $client = new Client(['base_uri' => $this->_eventsUri]);
+        $response = null;
 
         try {
             $options = $this->_requestOptions;
             $options['body'] = $payload;
             $response = $client->request('POST', '/bulk', $options);
-
-            return $response->getStatusCode() < 300;
         } catch (\Exception $e) {
             $this->_logger->warning("GuzzleEventPublisher::publish caught $e");
             return false;
         }
+        if ($response && ($response->getStatusCode() == 401)) {
+            throw new InvalidSDKKeyException();
+        }
+        return $response && ($response->getStatusCode() < 300);
     }
 }

src/LaunchDarkly/GuzzleFeatureRequester.php

@@ -65,7 +65,7 @@ public function get($key)
             if ($code == 404) {
                 $this->_logger->warning("GuzzleFeatureRequester::get returned 404. Feature flag does not exist for key: " . $key);
             } else {
-                $this->_logger->error("GuzzleFeatureRequester::get received an unexpected HTTP status code $code");
+                $this->handleUnexpectedStatus($code, "GuzzleFeatureRequester::get");
             }
             return null;
         }
@@ -83,9 +83,15 @@ public function getAll() {
             $body = $response->getBody();
             return array_map(FeatureFlag::getDecoder(), json_decode($body, true));
         } catch (BadResponseException $e) {
-            $code = $e->getResponse()->getStatusCode();
-            $this->_logger->error("GuzzleFeatureRequester::getAll received an unexpected HTTP status code $code");
+            $this->handleUnexpectedStatus($e->getResponse()->getStatusCode(), "GuzzleFeatureRequester::getAll");
             return null;
         }
     }
+
+    private function handleUnexpectedStatus($code, $method) {
+        $this->_logger->error("$method received an unexpected HTTP status code $code");
+        if ($code == 401) {
+            throw new InvalidSDKKeyException();
+        }
+    }
 }

src/LaunchDarkly/LDClient.php

@@ -5,6 +5,13 @@
 use Monolog\Logger;
 use Psr\Log\LoggerInterface;
 
+/**
+ * Used internally.
+ */
+class InvalidSDKKeyException extends \Exception
+{
+}
+
 /**
  * A client for the LaunchDarkly API.
  */
@@ -144,7 +151,12 @@ public function variation($key, $user, $default = false) {
             if ($user->isKeyBlank()) {
                 $this->_logger->warning("User key is blank. Flag evaluation will proceed, but the user will not be stored in LaunchDarkly.");
             }
-            $flag = $this->_featureRequester->get($key);
+            try {
+                $flag = $this->_featureRequester->get($key);
+            } catch (InvalidSDKKeyException $e) {
+                $this->handleInvalidSDKKey();
+                return $default;
+            }
 
             if (is_null($flag)) {
                 $this->_sendFlagRequestEvent($key, $user, $default, $default);
@@ -252,7 +264,15 @@ public function allFlags($user) {
             $this->_logger->warn("allFlags called with null user or null/empty user key! Returning null");
             return null;
         }
-        $flags = $this->_featureRequester->getAll();
+        if ($this->isOffline()) {
+            return null;
+        }
+        try {
+            $flags = $this->_featureRequester->getAll();
+        } catch (InvalidSDKKeyException $e) {
+            $this->handleInvalidSDKKey();
+            return null;
+        }
         if ($flags === null) {
             return null;
         }
@@ -285,7 +305,11 @@ public function secureModeHash($user) {
      */
     public function flush()
     {
-        return $this->_eventProcessor->flush();
+        try {
+            return $this->_eventProcessor->flush();
+        } catch (InvalidSDKKeyException $e) {
+            $this->handleInvalidSDKKey();
+        }
     }
 
     /**
@@ -310,4 +334,9 @@ protected function _get_default($key, $default) {
             return $default;
         }
     }
+
+    protected function handleInvalidSDKKey() {
+        $this->_logger->error("Received 401 error, no further HTTP requests will be made during lifetime of LDClient since SDK key is invalid");
+        $this->_offline = true;
+    }
 }