Merge pull request #11 from launchdarkly/jko/coerce-keys

Coerce user keys to strings

Author: jkodumal

src/LaunchDarkly/LDUser.php

@@ -33,7 +33,7 @@ class LDUser {
      * @param array|null   $custom    Other custom attributes that can be used to create custom rules
      */
     public function __construct($key, $secondary = null, $ip = null, $country = null, $email = null, $name = null, $avatar = null, $firstName = null, $lastName= null, $anonymous = null, $custom = []) {
-        $this->_key = $key;
+        $this->_key = strval($key);
         $this->_secondary = $secondary;
         $this->_ip = $ip;
         $this->_country = $country;

tests/LDUserTest.php

@@ -12,6 +12,12 @@ public function testLDUserKey() {
       $this->assertEquals("[email protected]", $user->toJSON()['key']);
     }
 
+    public function testCoerceLDUserKey() {
+      $user = (new LDUserBuilder(3))->build();
+      $this->assertEquals("string", gettype($user->getKey()));
+      $this->assertEquals("string", gettype($user->toJSON()['key']));
+    }
+
     public function testLDUserSecondary() {
       $user = (new LDUserBuilder("[email protected]"))->secondary("secondary")->build();
       $this->assertEquals("secondary", $user->getSecondary());