Merge pull request #20 from launchdarkly/jko/check-empty

Ensure that empty custom attributes are not serialized to json

Author: jkodumal

src/LaunchDarkly/LDUser.php

@@ -117,7 +117,7 @@ public function toJSON() {
         if (isset($this->_lastName)) {
             $json['lastName'] = $this->_lastName;
         }
-        if (isset($this->_custom)) {
+        if (isset($this->_custom) && !empty($this->_custom)) {
             $json['custom'] = $this->_custom;
         }
         if (isset($this->_anonymous)) {

tests/LDUserTest.php

@@ -21,6 +21,13 @@ public function testCoerceLDUserKey() {
         $this->assertEquals("string", gettype($json['key']));
     }
 
+    public function testEmptyCustom() {        
+        $builder = new LDUserBuilder("[email protected]");
+        $user = $builder->build();
+        $json = $user->toJSON();
+        $this->assertTrue(!isset($json['custom']));
+    }
+
     public function testLDUserSecondary() {
         $builder = new LDUserBuilder("[email protected]");
         $user = $builder->secondary("secondary")->build();