From 6bd6996731720e9cec4f4252b1c738c8c7eb4ed8 Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Thu, 28 Aug 2025 21:11:09 +0000 Subject: [PATCH 1/7] feat(components): update DialogTrigger popover padding - Change from var(--lp-spacing-300) to var(--lp-spacing-400) var(--lp-spacing-600) - Vertical padding: 8px -> 12px - Horizontal padding: 8px -> 20px - Aligns with other popover implementations in the codebase Co-Authored-By: cpursley@launchdarkly.com --- packages/components/src/styles/Popover.module.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/components/src/styles/Popover.module.css b/packages/components/src/styles/Popover.module.css index c1797a27a..a49cecd8d 100644 --- a/packages/components/src/styles/Popover.module.css +++ b/packages/components/src/styles/Popover.module.css @@ -37,7 +37,7 @@ } &[data-trigger='DialogTrigger'] { - padding: var(--lp-spacing-300); + padding: var(--lp-spacing-400) var(--lp-spacing-600); } &[data-trigger='ComboBoxDialog'] { From 08ef974aad4dab8508cf410d219d65379a070218 Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Thu, 28 Aug 2025 21:14:51 +0000 Subject: [PATCH 2/7] fix(components): correct horizontal padding to var(--lp-spacing-500) - Update horizontal padding from var(--lp-spacing-600) to var(--lp-spacing-500) - Horizontal padding: 20px -> 16px - Vertical padding remains 12px (var(--lp-spacing-400)) Co-Authored-By: cpursley@launchdarkly.com --- packages/components/src/styles/Popover.module.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/components/src/styles/Popover.module.css b/packages/components/src/styles/Popover.module.css index a49cecd8d..3e234a704 100644 --- a/packages/components/src/styles/Popover.module.css +++ b/packages/components/src/styles/Popover.module.css @@ -37,7 +37,7 @@ } &[data-trigger='DialogTrigger'] { - padding: var(--lp-spacing-400) var(--lp-spacing-600); + padding: var(--lp-spacing-400) var(--lp-spacing-500); } &[data-trigger='ComboBoxDialog'] { From e8c1918418eb045f0c5a3efccedbf80b18c1adeb Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Thu, 28 Aug 2025 21:16:17 +0000 Subject: [PATCH 3/7] chore: add changeset for DialogTrigger padding update Co-Authored-By: cpursley@launchdarkly.com --- .changeset/update-popover-padding.md | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 .changeset/update-popover-padding.md diff --git a/.changeset/update-popover-padding.md b/.changeset/update-popover-padding.md new file mode 100644 index 000000000..ceee93b6e --- /dev/null +++ b/.changeset/update-popover-padding.md @@ -0,0 +1,9 @@ +--- +"@launchpad-ui/components": patch +--- + +feat(components): update DialogTrigger popover padding + +Updates DialogTrigger popover padding from uniform 8px to differentiated vertical/horizontal padding: +- Vertical padding: 8px → 12px (var(--lp-spacing-400)) +- Horizontal padding: 8px → 16px (var(--lp-spacing-500)) From 6b2a1b2695ff8dac2726f04d8a7fa61565522829 Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Tue, 9 Sep 2025 20:50:32 +0000 Subject: [PATCH 4/7] refactor(components): use explicit size tokens instead of spacing tokens - Replace var(--lp-spacing-400) var(--lp-spacing-500) with var(--lp-size-12) var(--lp-size-16) - Update changeset description to reference size tokens for clarity - Addresses PR feedback from matthewferry Co-Authored-By: cpursley@launchdarkly.com --- .changeset/update-popover-padding.md | 4 ++-- packages/components/src/styles/Popover.module.css | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.changeset/update-popover-padding.md b/.changeset/update-popover-padding.md index ceee93b6e..5461ad6f2 100644 --- a/.changeset/update-popover-padding.md +++ b/.changeset/update-popover-padding.md @@ -5,5 +5,5 @@ feat(components): update DialogTrigger popover padding Updates DialogTrigger popover padding from uniform 8px to differentiated vertical/horizontal padding: -- Vertical padding: 8px → 12px (var(--lp-spacing-400)) -- Horizontal padding: 8px → 16px (var(--lp-spacing-500)) +- Vertical padding: 8px → 12px (var(--lp-size-12)) +- Horizontal padding: 8px → 16px (var(--lp-size-16)) diff --git a/packages/components/src/styles/Popover.module.css b/packages/components/src/styles/Popover.module.css index 3e234a704..1bc31bb6f 100644 --- a/packages/components/src/styles/Popover.module.css +++ b/packages/components/src/styles/Popover.module.css @@ -37,7 +37,7 @@ } &[data-trigger='DialogTrigger'] { - padding: var(--lp-spacing-400) var(--lp-spacing-500); + padding: var(--lp-size-12) var(--lp-size-16); } &[data-trigger='ComboBoxDialog'] { From 1ff346a552cdc837409671e6fdb4be27660257fd Mon Sep 17 00:00:00 2001 From: Matt Davis Date: Thu, 20 Nov 2025 11:30:13 -0800 Subject: [PATCH 5/7] fix(popover): keep existing padding on popovers with search inputs --- packages/components/src/styles/Popover.module.css | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/packages/components/src/styles/Popover.module.css b/packages/components/src/styles/Popover.module.css index 1503aa892..3cb4c3d92 100644 --- a/packages/components/src/styles/Popover.module.css +++ b/packages/components/src/styles/Popover.module.css @@ -43,11 +43,7 @@ padding: var(--lp-size-12) var(--lp-size-16); } - &:has(input[type='search']):is( - [data-trigger='Select'], - [data-trigger='MenuTrigger'], - [data-trigger='SubmenuTrigger'] - ) { + &:has(input[type='search']) { padding: var(--lp-spacing-300); } From af93f92f894f53984915a0a1060bbb6fc0a61613 Mon Sep 17 00:00:00 2001 From: Matt Davis Date: Thu, 20 Nov 2025 11:47:34 -0800 Subject: [PATCH 6/7] Revert "fix(popover): keep existing padding on popovers with search inputs" This reverts commit 1ff346a552cdc837409671e6fdb4be27660257fd. --- packages/components/src/styles/Popover.module.css | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/components/src/styles/Popover.module.css b/packages/components/src/styles/Popover.module.css index 3cb4c3d92..1503aa892 100644 --- a/packages/components/src/styles/Popover.module.css +++ b/packages/components/src/styles/Popover.module.css @@ -43,7 +43,11 @@ padding: var(--lp-size-12) var(--lp-size-16); } - &:has(input[type='search']) { + &:has(input[type='search']):is( + [data-trigger='Select'], + [data-trigger='MenuTrigger'], + [data-trigger='SubmenuTrigger'] + ) { padding: var(--lp-spacing-300); } From 2ab0d0a5bc1670f1d0062300227b78475a9c0872 Mon Sep 17 00:00:00 2001 From: Matt Davis Date: Thu, 20 Nov 2025 12:31:07 -0800 Subject: [PATCH 7/7] fix(autocomplete): update autocomplete stories --- packages/components/stories/Autocomplete.stories.tsx | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/components/stories/Autocomplete.stories.tsx b/packages/components/stories/Autocomplete.stories.tsx index f8f9c4908..347bf5960 100644 --- a/packages/components/stories/Autocomplete.stories.tsx +++ b/packages/components/stories/Autocomplete.stories.tsx @@ -6,12 +6,12 @@ import { expect, userEvent, within } from 'storybook/test'; import { Autocomplete } from '../src/Autocomplete'; import { Button } from '../src/Button'; -import { Dialog, DialogTrigger } from '../src/Dialog'; +import { Dialog } from '../src/Dialog'; import { Group } from '../src/Group'; import { IconButton } from '../src/IconButton'; import { Input } from '../src/Input'; import { ListBox, ListBoxItem } from '../src/ListBox'; -import { Menu, MenuItem } from '../src/Menu'; +import { Menu, MenuItem, MenuTrigger } from '../src/Menu'; import { Popover } from '../src/Popover'; import { SearchField } from '../src/SearchField'; @@ -45,7 +45,7 @@ export const Example: Story = { ]; return ( - + @@ -73,7 +73,7 @@ export const Example: Story = { - + ); }, ...open, @@ -89,7 +89,7 @@ export const ListBoxExample: Story = { ]; return ( - + @@ -118,7 +118,7 @@ export const ListBoxExample: Story = { - + ); }, ...open,