fixes

Author: wichopy

packages/store/node-server-sdk-mongodb/jest.config.js

@@ -0,0 +1,7 @@
+module.exports = {
+  transform: { '^.+\\.ts?$': 'ts-jest' },
+  testMatch: ['**/__tests__/**/*test.ts?(x)'],
+  testEnvironment: 'node',
+  moduleFileExtensions: ['ts', 'tsx', 'js', 'jsx', 'json', 'node'],
+  collectCoverageFrom: ['src/**/*.ts'],
+};

packages/store/node-server-sdk-mongodb/jest.config.json

@@ -3,6 +3,24 @@ import { interfaces, LDLogger } from '@launchdarkly/node-server-sdk';
 import LDMongoDBOptions from './LDMongoDBOptions';
 import MongoDBClientState from './MongoDBClientState';
 
+/**
+ * @internal
+ */
+interface MetadataDocument {
+  _id: string;
+  [FIELD_LAST_UP_TO_DATE]?: number;
+}
+
+/**
+ * @internal
+ */
+interface UserDocument {
+  _id?: string;
+  [FIELD_USER_HASH]: string;
+  [FIELD_INCLUDED]?: string[];
+  [FIELD_EXCLUDED]?: string[];
+}
+
 /**
  * @internal
  */
@@ -65,14 +83,14 @@ export default class MongoDBBigSegmentStore implements interfaces.BigSegmentStor
    */
   async getMetadata(): Promise<interfaces.BigSegmentStoreMetadata | undefined> {
     try {
-      const metadataCollection = await this._state.getCollection(COLLECTION_BIG_SEGMENTS_METADATA);
-
+      const metadataCollection = await this._state.getCollection<MetadataDocument>(COLLECTION_BIG_SEGMENTS_METADATA);
+      
       const metadata = await metadataCollection.findOne({ _id: METADATA_KEY });
-
+      
       if (metadata && metadata[FIELD_LAST_UP_TO_DATE]) {
         return { lastUpToDate: metadata[FIELD_LAST_UP_TO_DATE] };
       }
-
+      
       return {};
     } catch (error) {
       this._logger?.error(`MongoDB big segment store getMetadata error: ${error}`);
@@ -90,23 +108,23 @@ export default class MongoDBBigSegmentStore implements interfaces.BigSegmentStor
     userHash: string,
   ): Promise<interfaces.BigSegmentStoreMembership | undefined> {
     try {
-      const userCollection = await this._state.getCollection(COLLECTION_BIG_SEGMENTS_USER);
-
+      const userCollection = await this._state.getCollection<UserDocument>(COLLECTION_BIG_SEGMENTS_USER);
+      
       const userData = await userCollection.findOne({ [FIELD_USER_HASH]: userHash });
-
+      
       if (!userData) {
         return undefined;
       }
 
       const membership: interfaces.BigSegmentStoreMembership = {};
-
+      
       // Process excluded segment references
       if (userData[FIELD_EXCLUDED] && Array.isArray(userData[FIELD_EXCLUDED])) {
         userData[FIELD_EXCLUDED].forEach((segmentRef: string) => {
           membership[segmentRef] = false;
         });
       }
-
+      
       // Process included segment references
       if (userData[FIELD_INCLUDED] && Array.isArray(userData[FIELD_INCLUDED])) {
         userData[FIELD_INCLUDED].forEach((segmentRef: string) => {

packages/store/node-server-sdk-mongodb/src/MongoDBBigSegmentStore.ts

@@ -1,4 +1,4 @@
-import { Collection, Db, MongoClient, MongoServerError } from 'mongodb';
+import { Collection, Db, Document, MongoClient, MongoServerError } from 'mongodb';
 
 import LDMongoDBOptions from './LDMongoDBOptions';
 
@@ -45,7 +45,7 @@ export default class MongoDBClientState {
   /**
    * Gets a MongoDB collection by name.
    */
-  public async getCollection<T = any>(name: string): Promise<Collection<T>> {
+  public async getCollection<T extends Document = Document>(name: string): Promise<Collection<T>> {
     const db = await this.getDatabase();
     return db.collection<T>(this.prefixedCollection(name));
   }

packages/store/node-server-sdk-mongodb/src/MongoDBClientState.ts

@@ -2,6 +2,26 @@ import { interfaces, LDLogger } from '@launchdarkly/node-server-sdk';
 
 import MongoDBClientState from './MongoDBClientState';
 
+/**
+ * @internal
+ */
+interface FeatureDocument {
+  _id: string;
+  namespace: string;
+  version: number;
+  item?: string;
+  deleted?: boolean;
+}
+
+/**
+ * @internal
+ */
+interface InitializedDocument {
+  _id: string;
+  initialized: boolean;
+  timestamp: Date;
+}
+
 /**
  * @internal
  */
@@ -66,7 +86,7 @@ export default class MongoDBCore implements interfaces.PersistentDataStore {
 
       for (const collection of allData) {
         const { namespace } = collection.key;
-        const mongoCollection = await this._state.getCollection(namespace);
+        const mongoCollection = await this._state.getCollection<FeatureDocument>(namespace);
         const existingDocs = await mongoCollection.find({}, { projection: { _id: 1 } }).toArray();
 
         for (const doc of existingDocs) {
@@ -80,7 +100,7 @@ export default class MongoDBCore implements interfaces.PersistentDataStore {
       for (const collection of allData) {
         const { namespace } = collection.key;
         const items = collection.item;
-        const mongoCollection = await this._state.getCollection(namespace);
+        const mongoCollection = await this._state.getCollection<FeatureDocument>(namespace);
 
         // Prepare bulk operations for this namespace
         const bulkOps: any[] = [];
@@ -89,11 +109,11 @@ export default class MongoDBCore implements interfaces.PersistentDataStore {
           const itemKey = `${namespace}:${keyedItem.key}`;
           itemsToKeep.add(itemKey);
 
-          const doc: any = {
-            _id: keyedItem.key,
-            namespace,
-            version: keyedItem.item.version,
-          };
+        const doc: FeatureDocument = {
+          _id: keyedItem.key,
+          namespace,
+          version: keyedItem.item.version,
+        };
 
           if (keyedItem.item.deleted) {
             doc.deleted = true;
@@ -119,7 +139,7 @@ export default class MongoDBCore implements interfaces.PersistentDataStore {
       // Delete items that are no longer present in the new data
       for (const collection of allData) {
         const { namespace } = collection.key;
-        const mongoCollection = await this._state.getCollection(namespace);
+        const mongoCollection = await this._state.getCollection<FeatureDocument>(namespace);
 
         const itemsToDelete: string[] = [];
         for (const existingItem of existingItems) {
@@ -134,10 +154,10 @@ export default class MongoDBCore implements interfaces.PersistentDataStore {
       }
 
       // Set the initialized flag
-      const initCollection = await this._state.getCollection(COLLECTION_INITIALIZED);
+      const initCollection = await this._state.getCollection<InitializedDocument>(COLLECTION_INITIALIZED);
       await initCollection.replaceOne(
         { _id: this._initedKey },
-        { _id: this._initedKey, initialized: true, timestamp: new Date() },
+        { initialized: true, timestamp: new Date() } as any,
         { upsert: true }
       );
 
@@ -154,7 +174,7 @@ export default class MongoDBCore implements interfaces.PersistentDataStore {
     callback: (descriptor: interfaces.SerializedItemDescriptor | undefined) => void,
   ): Promise<void> {
     try {
-      const collection = await this._state.getCollection(kind.namespace);
+      const collection = await this._state.getCollection<FeatureDocument>(kind.namespace);
       const doc = await collection.findOne({ _id: key });
 
       if (doc) {
@@ -180,7 +200,7 @@ export default class MongoDBCore implements interfaces.PersistentDataStore {
     ) => void,
   ): Promise<void> {
     try {
-      const collection = await this._state.getCollection(kind.namespace);
+      const collection = await this._state.getCollection<FeatureDocument>(kind.namespace);
       const docs = await collection.find({ deleted: { $ne: true } }).toArray();
 
       const results: interfaces.KeyedItem<string, interfaces.SerializedItemDescriptor>[] = [];
@@ -213,9 +233,9 @@ export default class MongoDBCore implements interfaces.PersistentDataStore {
     ) => void,
   ): Promise<void> {
     try {
-      const collection = await this._state.getCollection(kind.namespace);
+      const collection = await this._state.getCollection<FeatureDocument>(kind.namespace);
 
-      const doc: any = {
+      const doc: FeatureDocument = {
         _id: key,
         namespace: kind.namespace,
         version: descriptor.version,
@@ -256,7 +276,7 @@ export default class MongoDBCore implements interfaces.PersistentDataStore {
 
   async initialized(callback: (isInitialized: boolean) => void): Promise<void> {
     try {
-      const collection = await this._state.getCollection(COLLECTION_INITIALIZED);
+      const collection = await this._state.getCollection<InitializedDocument>(COLLECTION_INITIALIZED);
       const doc = await collection.findOne({ _id: this._initedKey });
       callback(!!doc?.initialized);
     } catch (error) {

packages/store/node-server-sdk-mongodb/src/MongoDBCore.ts

@@ -4,7 +4,7 @@
     "rootDir": ".",
     "outDir": "dist",
     "target": "es2017",
-    "lib": ["es6"],
+    "lib": ["es2017"],
     "module": "commonjs",
     "strict": true,
     "noImplicitOverride": true,
@@ -15,7 +15,8 @@
     "declarationMap": true, // enables importers to jump to source
     "resolveJsonModule": true,
     "stripInternal": true,
-    "moduleResolution": "node"
+    "moduleResolution": "node",
+    "skipLibCheck": true
   },
   "exclude": ["**/*.test.ts", "dist", "node_modules", "__tests__"]
 }