prepare 1.1.2 release (#5)

Author: LaunchDarklyCI

build-android.gradle

@@ -9,7 +9,7 @@ buildscript {
         jcenter()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:3.6.0'
+        classpath 'com.android.tools.build:gradle:4.2.0'
     }
 }
 // This Gradle script is used only when we are running tests in an Android environment to verify
@@ -60,6 +60,14 @@ android {
 }
 
 dependencies {
+    // See note in build-shared.gradle on the purpose of "privateImplementation". The
+    // Android Gradle plugin doesn't seem to have a good way to customize the classpath
+    // of the compile and test tasks, but since we're not actually publishing any
+    // Android artifacts from this project (we use this build only for CI testing), we
+    // can simply copy the dependencies from "privateImplementation" into the standard
+    // "implementation" for the Android build.
+    implementation configurations.privateImplementation
+
     androidTestImplementation "junit:junit:4.12"
     androidTestImplementation "org.hamcrest:hamcrest-library:1.3"
     androidTestImplementation "com.android.support.test:runner:1.0.2"

build-shared.gradle

@@ -17,17 +17,36 @@ ext {
 
 ext.versions = [
     "gson": "2.7",
-    "jackson": "2.10.0"
+    "jacksonCore": "2.10.5",
+    "jacksonDatabind": "2.10.5.1"
 ]
 
 ext.libraries = [:]
 
+configurations {
+    privateImplementation
+}
+
 dependencies {
-    // Dependencies will not be exposed in the pom - see below in pom.withXml block
-    implementation "com.google.code.gson:gson:${versions.gson}"
-    implementation "com.fasterxml.jackson.core:jackson-core:${versions.jackson}"
-    implementation "com.fasterxml.jackson.core:jackson-databind:${versions.jackson}"
+    // The Gson and Jackson dependencies go into a custom configuration here, instead of
+    // the regular "implementation" configuration. We don't want them to be visible at
+    // all in the module's published dependencies - not even in "runtime" scope - because:
+    //
+    // 1. For Gson: While java-sdk-common does need Gson in order to work, the
+    // LaunchDarkly SDKs that use java-sdk-common have different strategies for packaging
+    // Gson. The Android SDK exposes it as a regular dependency; the Java server-side SDK
+    // embeds and shades Gson and does not expose it as a dependency. So we are leaving
+    // it up to the SDK to provide Gson in some way.
+    //
+    // 2. For Jackson: The SDKs do not use, require, or embed Jackson; we provide the
+    // LDJackson class as a convenience for applications that do use Jackson, and it is
+    // only usable if the application already has Jackson in its classpath. So we do not
+    // want Jackson to show up as a transitive  dependency.
+    privateImplementation "com.google.code.gson:gson:${versions.gson}"
+    privateImplementation "com.fasterxml.jackson.core:jackson-core:${versions.jacksonCore}"
+    privateImplementation "com.fasterxml.jackson.core:jackson-databind:${versions.jacksonDatabind}"
 
+    testImplementation configurations.privateImplementation
     testImplementation "org.hamcrest:hamcrest-library:1.3"
     testImplementation "junit:junit:4.12"
 }