fix: prevent flag change listener from being invoked with null flag key #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanderson-ld
commented
Jul 21, 2025
Contributor
Author
There was a problem hiding this comment.
For reviewers: Fixing flaky test due to hash map iteration order not being deterministic across runs.
louis-launchdarkly
approved these changes
Jul 21, 2025
Contributor
louis-launchdarkly
left a comment
louis-launchdarkly
left a comment
There was a problem hiding this comment.
As discussed, while it would be the best to know exactly what is triggering this, if we have a null key at this point, we can't find the correct listener to call anyway and it is better to silence it than crash.
tanderson-ld
pushed a commit
that referenced
this pull request
Jul 21, 2025
🤖 I have created a release *beep* *boop* --- ## [5.9.1](5.9.0...5.9.1) (2025-07-21) ### Bug Fixes * prevent flag change listener from being invoked with null flag key ([#307](#307)) ([feada66](feada66)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.