Skip to content

Commit 23b930f

Browse files
committed
Revert "[ch57098] Deprecate LDCountryCode (#141)" so we can do a patch release
first. This reverts commit c0e71ae.
1 parent ea19a16 commit 23b930f

File tree

2 files changed

+6
-23
lines changed

2 files changed

+6
-23
lines changed

launchdarkly-android-client-sdk/src/main/java/com/launchdarkly/android/LDCountryCode.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,6 @@
9696
*
9797
* @author Takahiko Kawasaki
9898
*/
99-
@SuppressWarnings({"deprecation", "DeprecatedIsStillUsed"})
100-
@Deprecated
10199
public enum LDCountryCode {
102100
/**
103101
* <a href="http://en.wikipedia.org/wiki/Ascension_Island">Ascension Island</a>

launchdarkly-android-client-sdk/src/main/java/com/launchdarkly/android/LDUser.java

Lines changed: 6 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,6 @@ public static class Builder {
211211
private String email;
212212
private String name;
213213
private String avatar;
214-
@SuppressWarnings("deprecation")
215214
private LDCountryCode country;
216215

217216
private final Map<String, JsonElement> custom;
@@ -233,7 +232,6 @@ public Builder(String key) {
233232
privateAttributeNames = new HashSet<>();
234233
}
235234

236-
@SuppressWarnings("deprecation")
237235
public Builder(LDUser user) {
238236
this.key = user.getKey();
239237
this.anonymous = user.getAnonymous();
@@ -284,12 +282,10 @@ public Builder privateSecondary(String s) {
284282
}
285283

286284
/**
287-
* Set the country for a user. In 2.x.x the SDK will attempt to look the country up as a <a
285+
* Set the country for a user. The country should be a valid <a
288286
* href="http://en.wikipedia.org/wiki/ISO_3166-1">ISO 3166-1</a> alpha-2 or alpha-3 code. If
289287
* it is not a valid ISO-3166-1 code, an attempt will be made to look up the country by its
290-
* name. If that fails, a warning will be logged, and the country will not be set. In the
291-
* next major release (3.0.0) the SDK will not attempt attempt this lookup, and instead
292-
* treat the country field as a normal String.
288+
* name. If that fails, a warning will be logged, and the country will not be set.
293289
*
294290
* @param s the country for the user
295291
* @return the builder
@@ -300,12 +296,11 @@ public Builder country(String s) {
300296
}
301297

302298
/**
303-
* Set the country for a user. In 2.x.x the SDK will attempt to look the country up as a <a
299+
* Set the country for a user. The country should be a valid <a
304300
* href="http://en.wikipedia.org/wiki/ISO_3166-1">ISO 3166-1</a> alpha-2 or alpha-3 code. If
305301
* it is not a valid ISO-3166-1 code, an attempt will be made to look up the country by its
306-
* name. If that fails, a warning will be logged, and the country will not be set. In the
307-
* next major release (3.0.0) the SDK will not attempt attempt this lookup, and instead
308-
* treat the country field as a normal String. Private attributes are not recorded in events.
302+
* name. If that fails, a warning will be logged, and the country will not be set. Private
303+
* attributes are not recorded in events.
309304
*
310305
* @param s the country for the user
311306
* @return the builder
@@ -315,8 +310,6 @@ public Builder privateCountry(String s) {
315310
return country(s);
316311
}
317312

318-
319-
@SuppressWarnings("deprecation")
320313
private LDCountryCode countryCode(String s) {
321314
LDCountryCode countryCode = LDCountryCode.getByCode(s, false);
322315

@@ -348,11 +341,7 @@ private LDCountryCode countryCode(String s) {
348341
*
349342
* @param country the country for the user
350343
* @return the builder
351-
* @deprecated As of version 2.9.1, in 3.0.0 the SDK will no longer include the
352-
* LDCountryCode class. Applications should use {@link #country(String)} instead.
353-
* */
354-
@Deprecated
355-
@SuppressWarnings("deprecation")
344+
*/
356345
public Builder country(LDCountryCode country) {
357346
this.country = country;
358347
return this;
@@ -363,11 +352,7 @@ public Builder country(LDCountryCode country) {
363352
*
364353
* @param country the country for the user
365354
* @return the builder
366-
* @deprecated As of version 2.9.1, in 3.0.0 the SDK will no longer include the
367-
* LDCountryCode class. Applications should use {@link #privateCountry(String)} instead.
368355
*/
369-
@Deprecated
370-
@SuppressWarnings("deprecation")
371356
public Builder privateCountry(LDCountryCode country) {
372357
privateAttributeNames.add(COUNTRY);
373358
return country(country);

0 commit comments

Comments
 (0)