Skip to content

Redirect homepage and handle invalid name #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 25, 2022
Merged

Redirect homepage and handle invalid name #9

merged 3 commits into from
Feb 25, 2022

Conversation

@driesvints
Copy link
Member

@driesvints driesvints commented Feb 25, 2022 •
edited
Loading

This PR does two things:

  • Adds a redirect to the laravel docs for the homepage. Currently it throws an empty 404 page.
  • Handle the validation exception and show a descriptive message to solve an infinite redirect loop issue

This is in response to laravel/framework#39182. This will not solve the following issue the OP got:

bash: line 1: syntax error near unexpected token `newline'
bash: line 1: `<!DOCTYPE html>'

I have no idea how to solve that with the bash pipe we document. I'll send an additional PR to the docs to clarify which characters you can use.

This was referenced Feb 25, 2022
Merged
Closed
@taylorotwell taylorotwell merged commit 2a2c8e9 into master Feb 25, 2022
@taylorotwell taylorotwell deleted the route-updates branch February 25, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taylorotwell taylorotwell Awaiting requested review from taylorotwell

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@driesvints @taylorotwell