Use phpseclib for generating keys #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/KeysCommandTest.php
Outdated
|
|
||
| public function testPrivateAndPublicKeysAreGenerated() | ||
| { | ||
| $command = Mockery::mock(\Laravel\Passport\Console\KeysCommand::class) |
Contributor
There was a problem hiding this comment.
No leading slash needed please.
Contributor
|
Have you tested this output exactly matches the other command? |
samgreenwood
force-pushed
the
phpseclib
branch
from
efe03a2 to
1f20297
Compare
Contributor
Author
|
CS fixes done. From what I can tell the keys generated are the same. |
|
I think it should be on require-dev. |
Member
|
It actually can't be require-dev because require-dev is only installed for the root package (laravel/framework) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the 'openssl' cli utility may not me available, especially on windows this may require some ceremony.
Updated this command to leverage phpseclib instead.