Merge pull request #392 from TimWolla/security-client-revoke

taylorotwell · web-flow · commit 81aaa785e76c · 2017-06-01T16:30:38.000-05:00
Fix ClientRepository::revoked() for deleted clients
diff --git a/src/ClientRepository.php b/src/ClientRepository.php
@@ -174,8 +174,9 @@ public function regenerateSecret(Client $client)
      */
     public function revoked($id)
     {
-        return Client::where('id', $id)
-                ->where('revoked', true)->exists();
+        $client = Client::find($id);
+
+        return is_null($client) || $client->revoked;
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -174,8 +174,9 @@ public function regenerateSecret(Client $client)`
`174`	`174`	`*/`
`175`	`175`	`public function revoked($id)`
`176`	`176`	`{`
`177`		`- return Client::where('id', $id)`
`178`		`- ->where('revoked', true)->exists();`
	`177`	`+ $client = Client::find($id);`
	`178`	`+`
	`179`	`+ return is_null($client) \|\| $client->revoked;`
`179`	`180`	`}`
`180`	`181`
`181`	`182`	`/**`