DestructiveAction interface

[hivokas]

Currently DestructiveAction is a class which I should extend. It'd be nice if we had a DestructiveAction interface which we could implement on any action, instead of extending a class. Same like we have ShouldQueue and other interfaces.

Some actions in our app don't extend directly from Laravel/Nova/Action which makes it impossible to utilize DestructiveAction.

Previously I was suggested overriding jsonSerialize (#3951 (comment)), but it's also not an ideal solution for us because our policy forbids running destructive actions without certain permissions.

It think it'd be nice if we had a first party interface for this, instead of coming up with workarounds.

It doesn't seem hard to implement in a backwards-compatible way in the core.

Appreciate in advance.

[crynobone]

I'm failing to see how an interface will help with

it's also not an ideal solution for us because our policy forbids running destructive actions without certain permissions

Doesn't extending jsonSerialize method works better since you can get the request from the container

[hivokas]

Currently we have:

public function authorizedToRunAction(NovaRequest $request, Action $action): bool
{
    if ($action instanceof DestructiveAction) { // `DestructiveAction` class here 
        return $this->authorizedToRunDestructiveAction($request, $action);
    }

    return Gate::forUser(Nova::user($request))->check('runAction', [$this->model(), $action]);
}

public function authorizedToRunDestructiveAction(NovaRequest $request, DestructiveAction $action): bool
{
    return Gate::forUser(Nova::user($request))->check('runDestructiveAction', [$this->model(), $action]);
}

With the interface we'll do this:

public function authorizedToRunAction(NovaRequest $request, Action $action): bool
{
    if ($action instanceof DestructiveAction) { // `DestructiveAction` interface here 
        return $this->authorizedToRunDestructiveAction($request, $action);
    }

    return Gate::forUser(Nova::user($request))->check('runAction', [$this->model(), $action]);
}

public function authorizedToRunDestructiveAction(NovaRequest $request, DestructiveAction $action): bool
{
    return Gate::forUser(Nova::user($request))->check('runDestructiveAction', [$this->model(), $action]);
}

[hivokas]

We have orders in our project, to make some logic reusable, we introduced abstract class OrderAction extends Action with some custom logic.

And then we do class ApproveOrder extends OrderAction, class CancelOrder extends OrderAction, etc.

The problem is that for example CancelOrder is destructive. With the interface we could easily mark it as destructive like this: class CancelOrder extends OrderAction implements DestructiveAction. But since DestructiveAction is a class (not interface) and we already extend from OrderAction, we cannot do it.

Hope it better explains the use-case.

[hivokas]

Proposed solution in the core:

• add Destructive interface;
• update DestructiveAction from class DestructiveAction extends Action to class DestructiveAction extends Action implements Destructive;
• update jsonSerialize() to use $action instanceof Destructive instead of $action instanceof DestructiveAction.