-
Notifications
You must be signed in to change notification settings - Fork 11.7k
Added some unit tests for quickRandom and random methods in SupportStrTest.php #5382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added some unit tests for quickRandom and random methods in SupportStrTest.php #5382
Conversation
|
Please use single quotes around |
|
Also, leave 2 blank lines between test methods. |
|
@GrahamCampbell thank you for your review I applied these changes. |
|
Please remove all trailing whitespace and squash to one commit. |
|
I research how can I squash to single commit I didn't do it before |
|
If it's going to be a problem, don't bother. It's not worth your time. |
|
I squashed my last 3 commits into a single |
|
Hmmm. There seems to be an issue with my browser displaying the page. Carry on... |
|
@GrahamCampbell are there any other problem? |
|
Not that I can see. You'll have to wait for @taylorotwell to review this. |
|
@GrahamCampbell thank you. |
|
Ideally, lines of code should be ordered the same in both functions. |
|
@taylorotwell are there any problem with this pr? |
|
@faridmovsumov Taylor can sometimes take a week or more to get around to reviewing some pulls. It may be better to ping him at the end of the month rather than a few days after sending this. |
…str-class Added some unit tests for quickRandom and random methods in SupportStrTest.php
No description provided.