-
Notifications
You must be signed in to change notification settings - Fork 11.7k
[10.x] Create new command EnumMakeCommand #50004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| <?php | ||
|
|
||
| namespace Illuminate\Foundation\Console; | ||
|
|
||
| use Illuminate\Console\Concerns\CreatesMatchingTest; | ||
| use Illuminate\Console\GeneratorCommand; | ||
| use Symfony\Component\Console\Attribute\AsCommand; | ||
| use Symfony\Component\Console\Input\{InputInterface, InputOption}; | ||
|
|
||
| #[AsCommand(name: 'make:enum')] | ||
| class EnumMakeCommand extends GeneratorCommand | ||
| { | ||
| use CreatesMatchingTest; | ||
|
|
||
| /** | ||
| * The console command name. | ||
| * | ||
| * @var string | ||
| */ | ||
| protected $name = 'make:enum'; | ||
|
|
||
| /** | ||
| * The console command description. | ||
| * | ||
| * @var string | ||
| */ | ||
| protected $description = 'Create a new enum class'; | ||
|
|
||
| /** | ||
| * The type of class being generated. | ||
| * | ||
| * @var string | ||
| */ | ||
| protected $type = 'Enum'; | ||
|
|
||
| /** | ||
| * Execute the console command. | ||
| * | ||
| * @return void | ||
| */ | ||
| public function handle() | ||
| { | ||
| if (parent::handle() === false && !$this->option('force')) { | ||
| return false; | ||
| } | ||
|
|
||
| if ($this->option('test')) { | ||
| $this->createTest(); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Create a model factory for the model. | ||
| * | ||
| * @return void | ||
| */ | ||
| protected function createTest() | ||
| { | ||
| $this->call('make:test', [ | ||
| 'name' => $this->qualifyClass($this->getNameInput()) . 'Test', | ||
| '--unit' => true, | ||
| ]); | ||
| } | ||
|
|
||
| /** | ||
| * Get the stub file for the generator. | ||
| * | ||
| * @return string | ||
| */ | ||
| protected function getStub() | ||
| { | ||
| return $this->resolveStubPath('/stubs/enum.stub'); | ||
| } | ||
|
|
||
| /** | ||
| * Resolve the fully-qualified path to the stub. | ||
| * | ||
| * @param string $stub | ||
| * @return string | ||
| */ | ||
| protected function resolveStubPath($stub) | ||
| { | ||
| return file_exists($customPath = $this->laravel->basePath(trim($stub, '/'))) | ||
| ? $customPath | ||
| : __DIR__ . $stub; | ||
| } | ||
|
|
||
| /** | ||
| * Get the default namespace for the class. | ||
| * | ||
| * @param string $rootNamespace | ||
| * @return string | ||
| */ | ||
| protected function getDefaultNamespace($rootNamespace) | ||
| { | ||
| return is_dir(app_path('Enums')) ? $rootNamespace . '\\Enums' : $rootNamespace; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| <?php | ||
|
|
||
| namespace {{ namespace }}; | ||
|
|
||
| enum {{ class }}: string | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why only a string and not an int?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What is the int|string suggestion? |
||
| { | ||
|
|
||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enum will not need tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not? I think testing enums are fairly commonplace.