[9.x] Replace raw invisible characters in regex expressions with counterpart Unicode regex notations #45666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t Unicode regex notations
Member
|
Needs better explanation, code examples, screenshots, etc. to explain what you are referring to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#41971 introduced regex selector update for invisible Unicode characters with additions in #44906.
This PR updates regex expressions by replacing raw invisible characters with counterpart Unicode regex notations to increase visibility of source code in text editors that don't support display of invisible characters labels or in VCS editors.
It also expands matching characters from U+FEFF|U+200B (in case of \Illuminate\Foundation\Http\Middleware::transform()) or from U+FEFF (in case of \Illuminate\Support\Str::squish()) to all characters of same group (\p{Cf} - invisible formatting indicator).