Skip to content

[9.x] Trim zwnbsp #41949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2022
Merged

[9.x] Trim zwnbsp #41949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e866bba
trim zwnbsp
rfvjyy Apr 13, 2022
9ac95c8
fix zwnbsp
rfvjyy Apr 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Illuminate/Foundation/Http/Middleware/TrimStrings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ protected function transform($key, $value)
return $value;
}

return is_string($value) ? preg_replace('~^\s+|\s+$~iu', '', $value) : $value;
return is_string($value) ? preg_replace('~^[\s]+|[\s]+$~iu', '', $value) : $value;
}

/**
Expand Down
3 changes: 3 additions & 0 deletions tests/Foundation/Http/Middleware/TrimStringsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ public function testTrimStringsNBSP()
$middleware = new TrimStrings;
$symfonyRequest = new SymfonyRequest([
// Here has some NBSP, but it still display to space.
// Please note, do not edit in browser
'abc' => '  123   ',
'zwnbsp' => ' ha ',
'xyz' => 'だ',
'foo' => 'ム',
'bar' => '  だ   ',
Expand All @@ -45,6 +47,7 @@ public function testTrimStringsNBSP()

$middleware->handle($request, function (Request $request) {
$this->assertSame('123', $request->get('abc'));
$this->assertSame('ha', $request->get('zwnbsp'));
$this->assertSame('だ', $request->get('xyz'));
$this->assertSame('ム', $request->get('foo'));
$this->assertSame('だ', $request->get('bar'));
Expand Down