-
Notifications
You must be signed in to change notification settings - Fork 11.7k
[8.x] move maintenance mode logic #40072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
wimulkeman
wants to merge
1
commit into
laravel:8.x
from
certegroep:#36474_enable_overwriting_maintenance_methods
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| <?php | ||
|
|
||
| namespace Illuminate\Foundation; | ||
|
|
||
| use function storage_path; | ||
|
|
||
| class MaintenanceMode | ||
| { | ||
| /** | ||
| * Determine if the application is currently down for maintenance. | ||
| * | ||
| * @return bool | ||
| */ | ||
| public function isDown(): bool | ||
| { | ||
| return file_exists($this->getDownFilePath()); | ||
| } | ||
|
|
||
| /** | ||
| * Determine if the application is currently up. | ||
| * | ||
| * @return bool | ||
| */ | ||
| public function isUp(): bool | ||
| { | ||
| return $this->isDown() === false; | ||
| } | ||
|
|
||
| /** | ||
| * Take the application down for maintenance. | ||
| * | ||
| * @param array $payload | ||
| * @return void | ||
| */ | ||
| public function down(array $payload): void | ||
| { | ||
| file_put_contents( | ||
| $this->getDownFilePath(), | ||
| json_encode($payload, JSON_PRETTY_PRINT) | ||
| ); | ||
| } | ||
|
|
||
| /** | ||
| * Take the application out of maintenance. | ||
| * | ||
| * @return void | ||
| */ | ||
| public function up(): void | ||
| { | ||
| if ($this->isDown() !== false) { | ||
| unlink($this->getDownFilePath()); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Get the payload which was provided while the application was placed into maintenance. | ||
| * | ||
| * @return array | ||
| */ | ||
| public function getPayload(): array | ||
| { | ||
| return json_decode(file_get_contents($this->getDownFilePath()), true); | ||
| } | ||
|
|
||
| /** | ||
| * Get the path where the file is stored that signals that the application is down for maintenance. | ||
| * | ||
| * @return string | ||
| */ | ||
| protected function getDownFilePath(): string | ||
| { | ||
| return storage_path('framework/down'); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to mention but you'll need to remove this change since this is still a breaking change.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest in that case to leave the PR to 9.x open instead. Introducing the method without updating the interface feels invalid to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's okay 👍