From 65c8e0c13323862d6e65432468bea2924e490629 Mon Sep 17 00:00:00 2001 From: Dries Vints Date: Fri, 12 Mar 2021 00:04:53 +0100 Subject: [PATCH 1/2] Fix Mailer contract returns (#36563) --- src/Illuminate/Contracts/Mail/Factory.php | 2 +- src/Illuminate/Mail/MailManager.php | 2 +- src/Illuminate/Support/Testing/Fakes/MailFake.php | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Illuminate/Contracts/Mail/Factory.php b/src/Illuminate/Contracts/Mail/Factory.php index 0719c0514595..fe45a2fd9cd8 100644 --- a/src/Illuminate/Contracts/Mail/Factory.php +++ b/src/Illuminate/Contracts/Mail/Factory.php @@ -8,7 +8,7 @@ interface Factory * Get a mailer instance by name. * * @param string|null $name - * @return \Illuminate\Mail\Mailer + * @return \Illuminate\Contracts\Mail\Mailer */ public function mailer($name = null); } diff --git a/src/Illuminate/Mail/MailManager.php b/src/Illuminate/Mail/MailManager.php index 97fcda7827c5..86acdde3e3aa 100644 --- a/src/Illuminate/Mail/MailManager.php +++ b/src/Illuminate/Mail/MailManager.php @@ -63,7 +63,7 @@ public function __construct($app) * Get a mailer instance by name. * * @param string|null $name - * @return \Illuminate\Mail\Mailer + * @return \Illuminate\Contracts\Mail\Mailer */ public function mailer($name = null) { diff --git a/src/Illuminate/Support/Testing/Fakes/MailFake.php b/src/Illuminate/Support/Testing/Fakes/MailFake.php index eb548b6910b3..a42fe341f40e 100644 --- a/src/Illuminate/Support/Testing/Fakes/MailFake.php +++ b/src/Illuminate/Support/Testing/Fakes/MailFake.php @@ -276,7 +276,7 @@ protected function queuedMailablesOf($type) * Get a mailer instance by name. * * @param string|null $name - * @return \Illuminate\Mail\Mailer + * @return \Illuminate\Contracts\Mail\Mailer */ public function mailer($name = null) { From e41557c6802c2bb3896d7266a1713b9f5834e5ca Mon Sep 17 00:00:00 2001 From: Reid Barden Date: Thu, 11 Mar 2021 20:29:33 -0500 Subject: [PATCH 2/2] Fixes restrictive type declaration Removes array declaration for methods should actually accept Arrayable|array. --- .../Foundation/Testing/Concerns/InteractsWithViews.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Illuminate/Foundation/Testing/Concerns/InteractsWithViews.php b/src/Illuminate/Foundation/Testing/Concerns/InteractsWithViews.php index 574009a68f95..bbc65c7a10c2 100644 --- a/src/Illuminate/Foundation/Testing/Concerns/InteractsWithViews.php +++ b/src/Illuminate/Foundation/Testing/Concerns/InteractsWithViews.php @@ -18,7 +18,7 @@ trait InteractsWithViews * @param \Illuminate\Contracts\Support\Arrayable|array $data * @return \Illuminate\Testing\TestView */ - protected function view(string $view, array $data = []) + protected function view(string $view, $data = []) { return new TestView(view($view, $data)); } @@ -30,7 +30,7 @@ protected function view(string $view, array $data = []) * @param \Illuminate\Contracts\Support\Arrayable|array $data * @return \Illuminate\Testing\TestView */ - protected function blade(string $template, array $data = []) + protected function blade(string $template, $data = []) { $tempDirectory = sys_get_temp_dir(); @@ -52,7 +52,7 @@ protected function blade(string $template, array $data = []) * @param \Illuminate\Contracts\Support\Arrayable|array $data * @return \Illuminate\Testing\TestView */ - protected function component(string $componentClass, array $data = []) + protected function component(string $componentClass, $data = []) { $component = $this->app->make($componentClass, $data);