[7.x] FileViewFinder: Resolve hinted paths #31804
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksdcsk
changed the title
Member
|
No plans to change this code right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regular paths added to the
FileViewFinderclass are resolved (i.e.converted to absolute paths), but hinted paths are not (stored in$hints). It would be logical and coherent to apply the same standard to all paths.What brings me to propose this pull requests is issue #31789. The problem is that vendors might register their views paths using the
addNamespacemethod by passing a relative path, that will be later used by other classes as provided. When views are cached, the path to the view matters, as its hash is used to identify the view. This pull request would solve some variations of that bug such as those described here.All tests were passed in my local environment.