[5.8] Rename markdown mail folder to text #26938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason for this rename is because it's actually the wrong name. Both the HTML and text directories can contain Markdown, which will be properly rendered. The markdown directory atm just contains the plain text views of the email message. Note that I chose the "text" naming and not the "plain text" naming because we already use the "text" naming through the codebase at the moment.
This was referenced Dec 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason for this rename is because it's actually the wrong name. Both the HTML and text directories can contain Markdown, which will be properly rendered. The markdown directory at the moment just contains the plain text views of the email message. This has been confusing to me and others quite a few times already.
Note that I chose the "text" naming and not the "plain text" naming because we already use the "text" naming through the codebase at the moment.
Unless I'm forgetting somewhere, I think I renamed the only occurrence of the directory name.
Also see #23076