Skip to content

Remove unnecessary else block in Support/Manager #20058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove unnecessary else block in Support/Manager #20058

wants to merge 1 commit into from

Conversation

@seriquynh
Copy link
Contributor

@seriquynh seriquynh commented Jul 14, 2017

  • I add some more methods into Support/Mananger to make createDriver method more clearly.
  • I think using is_callable is a safer solution than method_exists when someome uses private method.

@taylorotwell
Copy link
Member

taylorotwell commented Jul 14, 2017

I have no problems with else blocks.

@seriquynh
Copy link
Contributor Author

seriquynh commented Jul 14, 2017

I know it's just optional in this case. Thank you for reviewing.

@seriquynh seriquynh deleted the remove_unnecessary_else branch July 14, 2017 13:46
@deleugpn deleugpn mentioned this pull request Dec 14, 2017
Merged
@derekmd derekmd mentioned this pull request Mar 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@seriquynh @taylorotwell