From eb4f2ff126bc8c8ea8fd19b4e65916d67e857edb Mon Sep 17 00:00:00 2001 From: Peter van Westen Date: Tue, 2 May 2017 12:01:29 +0200 Subject: [PATCH 1/2] [5.4] Refactors if structure Refactors the `if` structure in `Parser::parameters` by using an early return (`continue` in `foreach`). This eliminates the use of the `else` keyword. --- src/Illuminate/Console/Parser.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/Illuminate/Console/Parser.php b/src/Illuminate/Console/Parser.php index 4ccc88dc3ea5..fccc6cce2554 100644 --- a/src/Illuminate/Console/Parser.php +++ b/src/Illuminate/Console/Parser.php @@ -64,9 +64,11 @@ protected static function parameters(array $tokens) foreach ($tokens as $token) { if (preg_match('/-{2,}(.*)/', $token, $matches)) { $options[] = static::parseOption($matches[1]); - } else { - $arguments[] = static::parseArgument($token); + + continue; } + + $arguments[] = static::parseArgument($token); } return [$arguments, $options]; From eed6031c994dd5fdd57084215b428c9400bc9312 Mon Sep 17 00:00:00 2001 From: Peter van Westen Date: Tue, 2 May 2017 12:02:05 +0200 Subject: [PATCH 2/2] Update Parser.php --- src/Illuminate/Console/Parser.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Illuminate/Console/Parser.php b/src/Illuminate/Console/Parser.php index fccc6cce2554..13cc385edb8b 100644 --- a/src/Illuminate/Console/Parser.php +++ b/src/Illuminate/Console/Parser.php @@ -64,7 +64,7 @@ protected static function parameters(array $tokens) foreach ($tokens as $token) { if (preg_match('/-{2,}(.*)/', $token, $matches)) { $options[] = static::parseOption($matches[1]); - + continue; }