Fix once basic error due to validate not setting lastAttempted. (#17500)

Signed-off-by: Jason Lewis <[email protected]>

Author: jasonlewis

src/Illuminate/Auth/SessionGuard.php

@@ -248,7 +248,7 @@ public function onceUsingId($id)
      */
     public function validate(array $credentials = [])
     {
-        $user = $this->provider->retrieveByCredentials($credentials);
+        $this->lastAttempted = $user = $this->provider->retrieveByCredentials($credentials);
 
         return $this->hasValidCredentials($user, $credentials);
     }

tests/Auth/AuthGuardTest.php

@@ -359,6 +359,27 @@ public function testUserUsesRememberCookieIfItExists()
         $this->assertTrue($guard->viaRemember());
     }
 
+    public function testLoginOnceSetsUser()
+    {
+        list($session, $provider, $request, $cookie) = $this->getMocks();
+        $guard = m::mock('Illuminate\Auth\SessionGuard', ['default', $provider, $session])->makePartial();
+        $user = m::mock('Illuminate\Contracts\Auth\Authenticatable');
+        $guard->getProvider()->shouldReceive('retrieveByCredentials')->once()->with(['foo'])->andReturn($user);
+        $guard->getProvider()->shouldReceive('validateCredentials')->once()->with($user, ['foo'])->andReturn(true);
+        $guard->shouldReceive('setUser')->once()->with($user);
+        $this->assertTrue($guard->once(['foo']));
+    }
+
+    public function testLoginOnceFailure()
+    {
+        list($session, $provider, $request, $cookie) = $this->getMocks();
+        $guard = m::mock('Illuminate\Auth\SessionGuard', ['default', $provider, $session])->makePartial();
+        $user = m::mock('Illuminate\Contracts\Auth\Authenticatable');
+        $guard->getProvider()->shouldReceive('retrieveByCredentials')->once()->with(['foo'])->andReturn($user);
+        $guard->getProvider()->shouldReceive('validateCredentials')->once()->with($user, ['foo'])->andReturn(false);
+        $this->assertFalse($guard->once(['foo']));
+    }
+
     protected function getGuard()
     {
         list($session, $provider, $request, $cookie) = $this->getMocks();