[8.x] Container - detect circular dependencies

Author: ahmedash95

src/Illuminate/Container/Container.php

@@ -6,6 +6,7 @@
 use Closure;
 use Exception;
 use Illuminate\Contracts\Container\BindingResolutionException;
+use Illuminate\Contracts\Container\CircularDependencyFoundException;
 use Illuminate\Contracts\Container\Container as ContainerContract;
 use LogicException;
 use ReflectionClass;
@@ -659,7 +660,7 @@ public function get($id)
         try {
             return $this->resolve($id);
         } catch (Exception $e) {
-            if ($this->has($id)) {
+            if ($this->has($id) || $e instanceof CircularDependencyFoundException) {
                 throw $e;
             }
 
@@ -839,6 +840,11 @@ public function build($concrete)
             return $this->notInstantiable($concrete);
         }
 
+        // Check for circular dependencies
+        if(in_array($concrete, $this->buildStack)) {
+            throw new CircularDependencyFoundException("Circular dependency while initiating [{$concrete}]");
+        }
+
         $this->buildStack[] = $concrete;
 
         $constructor = $reflector->getConstructor();

src/Illuminate/Contracts/Container/CircularDependencyFoundException.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace Illuminate\Contracts\Container;
+
+use Exception;
+use Psr\Container\ContainerExceptionInterface;
+
+class CircularDependencyFoundException extends Exception implements ContainerExceptionInterface
+{
+    //
+}

tests/Container/ContainerTest.php

@@ -5,6 +5,7 @@
 use Illuminate\Container\Container;
 use Illuminate\Container\EntryNotFoundException;
 use Illuminate\Contracts\Container\BindingResolutionException;
+use Illuminate\Contracts\Container\CircularDependencyFoundException;
 use PHPUnit\Framework\TestCase;
 use Psr\Container\ContainerExceptionInterface;
 use stdClass;
@@ -562,6 +563,31 @@ public function testContainerCanResolveClasses()
 
         $this->assertInstanceOf(ContainerConcreteStub::class, $class);
     }
+
+    public function testContainerCanCatchCircularDependency() {
+        $this->expectException(CircularDependencyFoundException::class);
+
+        $container = new Container;
+        $container->get(CircularAStub::class);
+    }
+}
+
+class CircularAStub {
+    public function __construct(CircularBStub $b) {
+
+    }
+}
+
+class CircularBStub {
+    public function __construct(CircularCStub $c) {
+
+    }
+}
+
+class CircularCStub {
+    public function __construct(CircularAStub $a) {
+
+    }
 }
 
 class ContainerConcreteStub