[12.x] Improve typehints for Http classes (#54783)

* typehints for Illuminate\Http

* remove

* remove phpstan-type

Author: cosmastech

src/Illuminate/Http/Client/Factory.php

@@ -62,14 +62,14 @@ class Factory
     /**
      * The recorded response array.
      *
-     * @var array
+     * @var list<array{0: \Illuminate\Http\Client\Request, 1: \Illuminate\Http\Client\Response|null}>
      */
     protected $recorded = [];
 
     /**
      * All created response sequences.
      *
-     * @var array
+     * @var list<\Illuminate\Http\Client\ResponseSequence>
      */
     protected $responseSequences = [];
 
@@ -195,7 +195,7 @@ public static function failedRequest($body = null, $status = 200, $headers = [])
      * Create a new connection exception for use during stubbing.
      *
      * @param  string|null  $message
-     * @return \GuzzleHttp\Promise\PromiseInterface
+     * @return \Closure(\Illuminate\Http\Client\Request): \GuzzleHttp\Promise\PromiseInterface
      */
     public static function failedConnection($message = null)
     {
@@ -221,7 +221,7 @@ public function sequence(array $responses = [])
     /**
      * Register a stub callable that will intercept requests and be able to return stub responses.
      *
-     * @param  callable|array|null  $callback
+     * @param  callable|array<string, mixed>|null  $callback
      * @return $this
      */
     public function fake($callback = null)
@@ -283,7 +283,7 @@ public function fakeSequence($url = '*')
      * Stub the given URL using the given callback.
      *
      * @param  string  $url
-     * @param  \Illuminate\Http\Client\Response|\GuzzleHttp\Promise\PromiseInterface|callable|int|string|array  $callback
+     * @param  \Illuminate\Http\Client\Response|\GuzzleHttp\Promise\PromiseInterface|callable|int|string|array|\Illuminate\Http\Client\ResponseSequence  $callback
      * @return $this
      */
     public function stubUrl($url, $callback)
@@ -371,7 +371,7 @@ public function recordRequestResponsePair($request, $response)
     /**
      * Assert that a request / response pair was recorded matching a given truth test.
      *
-     * @param  callable  $callback
+     * @param  callable|(\Closure(\Illuminate\Http\Client\Request, \Illuminate\Http\Client\Response|null): bool)  $callback
      * @return void
      */
     public function assertSent($callback)
@@ -385,7 +385,7 @@ public function assertSent($callback)
     /**
      * Assert that the given request was sent in the given order.
      *
-     * @param  array  $callbacks
+     * @param  list<string|(\Closure(\Illuminate\Http\Client\Request, \Illuminate\Http\Client\Response|null): bool)|callable>  $callbacks
      * @return void
      */
     public function assertSentInOrder($callbacks)
@@ -407,7 +407,7 @@ public function assertSentInOrder($callbacks)
     /**
      * Assert that a request / response pair was not recorded matching a given truth test.
      *
-     * @param  callable  $callback
+     * @param  callable|(\Closure(\Illuminate\Http\Client\Request, \Illuminate\Http\Client\Response|null): bool)  $callback
      * @return void
      */
     public function assertNotSent($callback)
@@ -460,8 +460,8 @@ public function assertSequencesAreEmpty()
     /**
      * Get a collection of the request / response pairs matching the given truth test.
      *
-     * @param  callable  $callback
-     * @return \Illuminate\Support\Collection
+     * @param  (\Closure(\Illuminate\Http\Client\Request, \Illuminate\Http\Client\Response|null): bool)|callable  $callback
+     * @return \Illuminate\Support\Collection<int, array{0: \Illuminate\Http\Client\Request, 1: \Illuminate\Http\Client\Response|null}>
      */
     public function recorded($callback = null)
     {

src/Illuminate/Http/Client/Pool.php

@@ -26,7 +26,7 @@ class Pool
     /**
      * The pool of requests.
      *
-     * @var array
+     * @var array<array-key, \Illuminate\Http\Client\PendingRequest>
      */
     protected $pool = [];
 
@@ -65,7 +65,7 @@ protected function asyncRequest()
     /**
      * Retrieve the requests in the pool.
      *
-     * @return array
+     * @return array<array-key, \Illuminate\Http\Client\PendingRequest>
      */
     public function getRequests()
     {

src/Illuminate/Http/Client/Response.php

@@ -235,7 +235,7 @@ public function serverError()
     /**
      * Execute the given callback if there was a server or client error.
      *
-     * @param  callable  $callback
+     * @param  callable|(\Closure(\Illuminate\Http\Client\Response): mixed)  $callback
      * @return $this
      */
     public function onError(callable $callback)
@@ -339,7 +339,7 @@ public function throwIf($condition)
     /**
      * Throw an exception if the response status code matches the given code.
      *
-     * @param  callable|int  $statusCode
+     * @param  int|(\Closure(int, \Illuminate\Http\Client\Response): bool)|callable  $statusCode
      * @return $this
      *
      * @throws \Illuminate\Http\Client\RequestException
@@ -357,7 +357,7 @@ public function throwIfStatus($statusCode)
     /**
      * Throw an exception unless the response status code matches the given code.
      *
-     * @param  callable|int  $statusCode
+     * @param  int|(\Closure(int, \Illuminate\Http\Client\Response): bool)|callable  $statusCode
      * @return $this
      *
      * @throws \Illuminate\Http\Client\RequestException