Invert the firstOrNew if statement

tonysm · tonysm · commit 8a2ca69a640f · 2023-09-25T23:27:41.000-03:00
diff --git a/src/Illuminate/Database/Eloquent/Relations/HasManyThrough.php b/src/Illuminate/Database/Eloquent/Relations/HasManyThrough.php
@@ -256,11 +256,11 @@ protected function buildDictionary(Collection $results)
      */
     public function firstOrNew(array $attributes = [], array $values = [])
     {
-        if (is_null($instance = $this->where($attributes)->first())) {
-            $instance = $this->related->newInstance(array_merge($attributes, $values));
+        if (! is_null($instance = $this->where($attributes)->first())) {
+            return $instance;
         }
 
-        return $instance;
+        return $this->related->newInstance(array_merge($attributes, $values));
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -256,11 +256,11 @@ protected function buildDictionary(Collection $results)`
`256`	`256`	`*/`
`257`	`257`	`public function firstOrNew(array $attributes = [], array $values = [])`
`258`	`258`	`{`
`259`		`- if (is_null($instance = $this->where($attributes)->first())) {`
`260`		`- $instance = $this->related->newInstance(array_merge($attributes, $values));`
	`259`	`+ if (! is_null($instance = $this->where($attributes)->first())) {`
	`260`	`+ return $instance;`
`261`	`261`	`}`
`262`	`262`
`263`		`- return $instance;`
	`263`	`+ return $this->related->newInstance(array_merge($attributes, $values));`
`264`	`264`	`}`
`265`	`265`
`266`	`266`	`/**`