Enhancing updateOrCreate() to Use firstOrCreate() (#48160)

mpyw · web-flow · commit 80e0262a978e · 2023-08-27T10:12:26.000-05:00
diff --git a/src/Illuminate/Database/Eloquent/Builder.php b/src/Illuminate/Database/Eloquent/Builder.php
@@ -595,8 +595,10 @@ public function createOrFirst(array $attributes = [], array $values = [])
      */
     public function updateOrCreate(array $attributes, array $values = [])
     {
-        return tap($this->firstOrNew($attributes), function ($instance) use ($values) {
-            $instance->fill($values)->save();
+        return tap($this->firstOrCreate($attributes, $values), function ($instance) use ($values) {
+            if (! $instance->wasRecentlyCreated) {
+                $instance->fill($values)->save();
+            }
         });
     }
 

Original file line number	Diff line number	Diff line change
`@@ -595,8 +595,10 @@ public function createOrFirst(array $attributes = [], array $values = [])`
`595`	`595`	`*/`
`596`	`596`	`public function updateOrCreate(array $attributes, array $values = [])`
`597`	`597`	`{`
`598`		`- return tap($this->firstOrNew($attributes), function ($instance) use ($values) {`
`599`		`- $instance->fill($values)->save();`
	`598`	`+ return tap($this->firstOrCreate($attributes, $values), function ($instance) use ($values) {`
	`599`	`+ if (! $instance->wasRecentlyCreated) {`
	`600`	`+ $instance->fill($values)->save();`
	`601`	`+ }`
`600`	`602`	`});`
`601`	`603`	`}`
`602`	`604`