[12.X] Fix Http::preventStrayRequests error propagation when using Http::pool (#55689)

* add a dedicated error for stray request exception

* re-throw the error if it happens in a pool context

* update tests

* fix test

* fix

* fix

Author: LeTamanoir

src/Illuminate/Http/Client/PendingRequest.php

@@ -26,7 +26,6 @@
 use OutOfBoundsException;
 use Psr\Http\Message\MessageInterface;
 use Psr\Http\Message\RequestInterface;
-use RuntimeException;
 use Symfony\Component\VarDumper\VarDumper;
 
 class PendingRequest
@@ -1033,7 +1032,11 @@ protected function makePromise(string $method, string $url, array $options = [],
                     $this->dispatchResponseReceivedEvent($response);
                 });
             })
-            ->otherwise(function (OutOfBoundsException|TransferException $e) {
+            ->otherwise(function (OutOfBoundsException|TransferException|StrayRequestException $e) {
+                if ($e instanceof StrayRequestException) {
+                    throw $e;
+                }
+
                 if ($e instanceof ConnectException || ($e instanceof RequestException && ! $e->hasResponse())) {
                     $exception = new ConnectionException($e->getMessage(), 0, $e);
 
@@ -1334,7 +1337,7 @@ public function buildStubHandler()
 
                 if (is_null($response)) {
                     if ($this->preventStrayRequests) {
-                        throw new RuntimeException('Attempted request to ['.(string) $request->getUri().'] without a matching fake.');
+                        throw new StrayRequestException((string) $request->getUri());
                     }
 
                     return $handler($request, $options);

src/Illuminate/Http/Client/StrayRequestException.php

@@ -0,0 +1,13 @@
+<?php
+
+namespace Illuminate\Http\Client;
+
+use RuntimeException;
+
+class StrayRequestException extends RuntimeException
+{
+    public function __construct(string $uri)
+    {
+        parent::__construct('Attempted request to ['.$uri.'] without a matching fake.');
+    }
+}

tests/Http/HttpClientTest.php

@@ -21,6 +21,7 @@
 use Illuminate\Http\Client\RequestException;
 use Illuminate\Http\Client\Response;
 use Illuminate\Http\Client\ResponseSequence;
+use Illuminate\Http\Client\StrayRequestException;
 use Illuminate\Http\Response as HttpResponse;
 use Illuminate\Support\Arr;
 use Illuminate\Support\Carbon;
@@ -3178,12 +3179,38 @@ public function testItCanEnforceFaking()
         $responses[] = $this->factory->get('https://forge.laravel.com')->body();
         $this->assertSame(['ok', 'ok'], $responses);
 
-        $this->expectException(RuntimeException::class);
+        $this->expectException(StrayRequestException::class);
         $this->expectExceptionMessage('Attempted request to [https://laravel.com] without a matching fake.');
 
         $this->factory->get('https://laravel.com');
     }
 
+    public function testItCanEnforceFakingInThePool()
+    {
+        $this->factory->preventStrayRequests();
+        $this->factory->fake(['https://vapor.laravel.com' => Factory::response('ok', 200)]);
+        $this->factory->fake(['https://forge.laravel.com' => Factory::response('ok', 200)]);
+
+        $responses = $this->factory->pool(function (Pool $pool) {
+            return [
+                $pool->get('https://vapor.laravel.com'),
+                $pool->get('https://forge.laravel.com'),
+            ];
+        });
+
+        $this->assertSame(200, $responses[0]->status());
+        $this->assertSame(200, $responses[1]->status());
+
+        $this->expectException(StrayRequestException::class);
+        $this->expectExceptionMessage('Attempted request to [https://laravel.com] without a matching fake.');
+
+        $this->factory->pool(function (Pool $pool) {
+            return [
+                $pool->get('https://laravel.com'),
+            ];
+        });
+    }
+
     public function testPreventingStrayRequests()
     {
         $this->assertFalse($this->factory->preventingStrayRequests());