Switch to hash_equals (#49721)

simonhamp · web-flow · commit 72e9965635b7 · 2024-01-17T09:07:27.000-06:00
diff --git a/src/Illuminate/Filesystem/Filesystem.php b/src/Illuminate/Filesystem/Filesystem.php
@@ -546,7 +546,7 @@ public function hasSameHash($firstFile, $secondFile)
     {
         $hash = @md5_file($firstFile);
 
-        return $hash && $hash === @md5_file($secondFile);
+        return $hash && hash_equals($hash, (string) @md5_file($secondFile));
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -546,7 +546,7 @@ public function hasSameHash($firstFile, $secondFile)`
`546`	`546`	`{`
`547`	`547`	`$hash = @md5_file($firstFile);`
`548`	`548`
`549`		`- return $hash && $hash === @md5_file($secondFile);`
	`549`	`+ return $hash && hash_equals($hash, (string) @md5_file($secondFile));`
`550`	`550`	`}`
`551`	`551`
`552`	`552`	`/**`