Make stronger assertion before caching commands (#40628)

lorisleiva · web-flow · commit 2ac8fbb6fe06 · 2022-01-25T13:40:32.000-06:00
diff --git a/src/Illuminate/Console/Application.php b/src/Illuminate/Console/Application.php
@@ -267,7 +267,7 @@ protected function addToParent(SymfonyCommand $command)
      */
     public function resolve($command)
     {
-        if (class_exists($command) && ($commandName = $command::getDefaultName())) {
+        if (is_subclass_of($command, SymfonyCommand::class) && ($commandName = $command::getDefaultName())) {
             $this->commandMap[$commandName] = $command;
 
             return null;

Original file line number	Diff line number	Diff line change
`@@ -267,7 +267,7 @@ protected function addToParent(SymfonyCommand $command)`
`267`	`267`	`*/`
`268`	`268`	`public function resolve($command)`
`269`	`269`	`{`
`270`		`- if (class_exists($command) && ($commandName = $command::getDefaultName())) {`
	`270`	`+ if (is_subclass_of($command, SymfonyCommand::class) && ($commandName = $command::getDefaultName())) {`
`271`	`271`	`$this->commandMap[$commandName] = $command;`
`272`	`272`
`273`	`273`	`return null;`