wip (#36356)

Author: crnkovic

src/Illuminate/View/Compilers/Concerns/CompilesInjections.php

@@ -12,12 +12,12 @@ trait CompilesInjections
      */
     protected function compileInject($expression)
     {
-        $segments = explode(',', preg_replace("/[\(\)\\\"\']/", '', $expression));
+        $segments = explode(',', preg_replace("/[\(\)]/", '', $expression));
 
-        $variable = trim($segments[0]);
+        $variable = trim($segments[0], " '\"");
 
         $service = trim($segments[1]);
 
-        return "<?php \${$variable} = app('{$service}'); ?>";
+        return "<?php \${$variable} = app({$service}); ?>";
     }
 }

tests/View/Blade/BladeInjectTest.php

@@ -0,0 +1,34 @@
+<?php
+
+namespace Illuminate\Tests\View\Blade;
+
+class BladeInjectTest extends AbstractBladeTestCase
+{
+    public function testDependenciesInjectedAsStringsAreCompiled()
+    {
+        $string = "Foo @inject('baz', 'SomeNamespace\SomeClass') bar";
+        $expected = "Foo <?php \$baz = app('SomeNamespace\SomeClass'); ?> bar";
+        $this->assertEquals($expected, $this->compiler->compileString($string));
+    }
+
+    public function testDependenciesInjectedAsStringsAreCompiledWhenInjectedWithDoubleQuotes()
+    {
+        $string = 'Foo @inject("baz", "SomeNamespace\SomeClass") bar';
+        $expected = 'Foo <?php $baz = app("SomeNamespace\SomeClass"); ?> bar';
+        $this->assertEquals($expected, $this->compiler->compileString($string));
+    }
+
+    public function testDependenciesAreCompiled()
+    {
+        $string = "Foo @inject('baz', SomeNamespace\SomeClass::class) bar";
+        $expected = "Foo <?php \$baz = app(SomeNamespace\SomeClass::class); ?> bar";
+        $this->assertEquals($expected, $this->compiler->compileString($string));
+    }
+
+    public function testDependenciesAreCompiledWithDoubleQuotes()
+    {
+        $string = 'Foo @inject("baz", SomeNamespace\SomeClass::class) bar';
+        $expected = "Foo <?php \$baz = app(SomeNamespace\SomeClass::class); ?> bar";
+        $this->assertEquals($expected, $this->compiler->compileString($string));
+    }
+}