lint: run linter (#189)

linter is probably disabled on CI -- we'll need to do a bunch of line
wraps later on

Author: eyurtsev

Makefile

@@ -27,11 +27,12 @@ lint_diff format_diff: PYTHON_FILES=$(shell git diff --relative=. --name-only --
 
 lint lint_diff:
 	[ "$(PYTHON_FILES)" = "" ] ||	poetry run ruff format $(PYTHON_FILES) --diff
+	[ "$(PYTHON_FILES)" = "" ] ||	poetry run ruff check $(PYTHON_FILES) --diff
 	[ "$(PYTHON_FILES)" = "" ] || poetry run mypy $(PYTHON_FILES)
 
 format format_diff:
 	[ "$(PYTHON_FILES)" = "" ] || poetry run ruff format $(PYTHON_FILES)
-	[ "$(PYTHON_FILES)" = "" ] || poetry run ruff --fix $(PYTHON_FILES)
+	[ "$(PYTHON_FILES)" = "" ] || poetry run ruff check --fix $(PYTHON_FILES)
 
 spell_check:
 	poetry run codespell --toml pyproject.toml

langchain_postgres/__init__.py

@@ -1,8 +1,8 @@
 from importlib import metadata
 
 from langchain_postgres.chat_message_histories import PostgresChatMessageHistory
-from langchain_postgres.v2.engine import Column, PGEngine, ColumnDict
 from langchain_postgres.translator import PGVectorTranslator
+from langchain_postgres.v2.engine import Column, ColumnDict, PGEngine
 from langchain_postgres.v2.vectorstores import PGVectorStore
 from langchain_postgres.vectorstores import PGVector
 

langchain_postgres/utils/pgvector_migrator.py

@@ -68,7 +68,7 @@ async def __aextract_pgvector_collection(
                 if not rows:
                     break
                 yield [row._mapping for row in rows]
-    except ValueError as e:
+    except ValueError:
         raise ValueError(f"Collection, {collection_name} does not exist.")
     except SQLAlchemyError as e:
         raise ProgrammingError(

langchain_postgres/v2/engine.py

@@ -3,15 +3,12 @@
 import asyncio
 from dataclasses import dataclass
 from threading import Thread
-from typing import TYPE_CHECKING, Any, Awaitable, Optional, TypeVar, TypedDict, Union
+from typing import Any, Awaitable, Optional, TypedDict, TypeVar, Union
 
 from sqlalchemy import text
 from sqlalchemy.engine import URL
 from sqlalchemy.ext.asyncio import AsyncEngine, create_async_engine
 
-if TYPE_CHECKING:
-    import asyncpg  # type: ignore
-
 T = TypeVar("T")
 
 

langchain_postgres/vectorstores.py

@@ -5,6 +5,7 @@
 import enum
 import logging
 import uuid
+import warnings
 from typing import (
     Any,
     AsyncGenerator,
@@ -19,7 +20,6 @@
     Type,
     Union,
 )
-import warnings
 from typing import (
     cast as typing_cast,
 )

tests/unit_tests/v2/test_engine.py

@@ -2,7 +2,6 @@
 import uuid
 from typing import AsyncIterator, Sequence
 
-import asyncpg  # type: ignore
 import pytest
 import pytest_asyncio
 from langchain_core.embeddings import DeterministicFakeEmbedding
@@ -11,7 +10,7 @@
 from sqlalchemy.ext.asyncio import create_async_engine
 from sqlalchemy.pool import NullPool
 
-from langchain_postgres import Column, PGEngine, ColumnDict
+from langchain_postgres import Column, PGEngine
 from tests.utils import VECTORSTORE_CONNECTION_STRING as CONNECTION_STRING
 
 DEFAULT_TABLE = "default" + str(uuid.uuid4()).replace("-", "_")
@@ -214,7 +213,7 @@ async def test_from_connection_string_url_error(
     ) -> None:
         with pytest.raises(ValueError):
             PGEngine.from_connection_string(
-                f"postgresql+pg8000://user:password@host:port/db_name",
+                "postgresql+pg8000://user:password@host:port/db_name",
             )
 
     async def test_column(self, engine: PGEngine) -> None:

tests/unit_tests/v2/test_indexes.py

@@ -1,4 +1,5 @@
 import warnings
+
 import pytest
 
 from langchain_postgres.v2.indexes import (

tests/unit_tests/v2/test_pg_vectorstore_from_methods.py

@@ -6,9 +6,8 @@
 import pytest_asyncio
 from langchain_core.documents import Document
 from langchain_core.embeddings import DeterministicFakeEmbedding
-from sqlalchemy import VARCHAR, text
+from sqlalchemy import text
 from sqlalchemy.engine.row import RowMapping
-from sqlalchemy.ext.asyncio import create_async_engine
 
 from langchain_postgres import Column, PGEngine, PGVectorStore
 from tests.utils import VECTORSTORE_CONNECTION_STRING as CONNECTION_STRING