search decendants member (fix: #5)

Author: kyoh86

exportloopref.go

@@ -257,25 +257,13 @@ func (s *Searcher) isVar(loop ast.Node, expr ast.Expr) bool {
 func (s *Searcher) getIdentity(expr ast.Expr) *ast.Ident {
 	switch typed := expr.(type) {
 	case *ast.SelectorExpr:
-		// Get parent identity; i.e. `a` of the `a.b`.
-		parent, ok := typed.X.(*ast.Ident)
-		if !ok {
-			return nil
-		}
-
-		// parent is a package name identity
-		if parent.Obj == nil {
-			return nil
-		}
-
 		// Ignore if the parent is pointer ref (fix for #2)
-		if _, ok := s.Types[parent].Type.(*types.Pointer); ok {
+		if _, ok := s.Types[typed.X].Type.(*types.Pointer); ok {
 			return nil
 		}
 
-		// NOTE: If that is descendants member like `a.b.c`,
-		//       typed.X will be `*ast.SelectorExpr` `a.b`.
-		return parent
+		// Get parent identity; i.e. `a.b` of the `a.b.c`.
+		return s.getIdentity(typed.X)
 
 	case *ast.Ident:
 		// Get simple identity; i.e. `a` of the `a`.

exportloopref_test.go

@@ -36,3 +36,13 @@ func TestIssue2(t *testing.T) {
 	testdata := analysistest.TestData()
 	analysistest.Run(t, testdata, exportloopref.Analyzer, "issue2")
 }
+
+func TestDeep(t *testing.T) {
+	testdata := analysistest.TestData()
+	analysistest.Run(t, testdata, exportloopref.Analyzer, "deep")
+}
+
+func TestDepPointer(t *testing.T) {
+	testdata := analysistest.TestData()
+	analysistest.Run(t, testdata, exportloopref.Analyzer, "deeppointer")
+}

testdata/src/deep/deep.go

@@ -0,0 +1,45 @@
+package main
+
+type Container struct {
+	Inner
+}
+
+type Inner struct {
+	Number int
+}
+
+func main() {
+	var array [4]*int
+	var slice []*int
+	var ref *int
+	var str struct{ x *int }
+
+	var target = []Container{{Inner{10}}, {Inner{11}}, {Inner{12}}, {Inner{13}}}
+
+	// access to unsafe member
+	println("loop expecting 10, 11, 12, 13")
+	for i, p := range target {
+		printp(&p.Inner.Number)
+		slice = append(slice, &p.Inner.Number) // want "exporting a pointer for the loop variable p"
+		array[i] = &p.Inner.Number             // want "exporting a pointer for the loop variable p"
+		if i%2 == 0 {
+			ref = &p.Inner.Number   // want "exporting a pointer for the loop variable p"
+			str.x = &p.Inner.Number // want "exporting a pointer for the loop variable p"
+		}
+	}
+
+	println(`slice expecting "10, 11, 12, 13" but "13, 13, 13, 13"`)
+	for _, p := range slice {
+		printp(p)
+	}
+	println(`array expecting "10, 11, 12, 13" but "13, 13, 13, 13"`)
+	for _, p := range array {
+		printp(p)
+	}
+	println(`captured value expecting "12" but "13"`)
+	printp(ref)
+}
+
+func printp(p *int) {
+	println(*p)
+}

testdata/src/deeppointer/deeppointer.go

@@ -0,0 +1,45 @@
+package main
+
+type Container struct {
+	Pointer *Inner
+}
+
+type Inner struct {
+	Number int
+}
+
+func main() {
+	var array [4]*int
+	var slice []*int
+	var ref *int
+	var str struct{ x *int }
+
+	target := []Container{{&Inner{10}}, {&Inner{11}}, {&Inner{12}}, {&Inner{13}}}
+
+	// access to unsafe member
+	println("loop expecting 10, 11, 12, 13")
+	for i, p := range target {
+		printp(&p.Pointer.Number)
+		slice = append(slice, &p.Pointer.Number)
+		array[i] = &p.Pointer.Number
+		if i%2 == 0 {
+			ref = &p.Pointer.Number
+			str.x = &p.Pointer.Number
+		}
+	}
+
+	println(`slice expecting "10, 11, 12, 13"`)
+	for _, p := range slice {
+		printp(p)
+	}
+	println(`array expecting "10, 11, 12, 13"`)
+	for _, p := range array {
+		printp(p)
+	}
+	println(`captured value expecting "12"`)
+	printp(ref)
+}
+
+func printp(p *int) {
+	println(*p)
+}